Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of submenu children of toolbars #11910

Merged
merged 4 commits into from
Nov 28, 2022
Merged

Fix handling of submenu children of toolbars #11910

merged 4 commits into from
Nov 28, 2022

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes the error reported here, but does not register the menus at the heart of #11730.

How to test

  1. Install the Git builtin.
  2. Open the ... menu on the SCM view container.
  3. You should see a group of menus like this:

image

Or, without the @theia/git package:

image

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added git issues related to git menus issues related to the menu builtins Issues related to VS Code builtin extensions labels Nov 22, 2022
@msujew msujew self-requested a review November 25, 2022 15:40
msujew
msujew approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

  • Menus contributed by the git extension are correctly displayed
  • Normal nested/composite menus continue to work as expected

packages/core/src/common/menu/menu-model-registry.ts Show resolved Hide resolved
@colin-grant-work colin-grant-work merged commit c3ba8a9 into eclipse-theia:master Nov 28, 2022
@colin-grant-work colin-grant-work deleted the bugfix/git-submenu branch November 28, 2022 17:37
@colin-grant-work colin-grant-work added this to the 1.33.0 milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

@vince-fugnitto vince-fugnitto Awaiting requested review from vince-fugnitto

Assignees
No one assigned
Labels
builtins Issues related to VS Code builtin extensions git issues related to git menus issues related to the menu
Projects
None yet
Milestone
1.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-grant-work @msujew