Fix package resolving failure in CLI #11830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
With the introduction of ESM modules, a lot of packages have started to utilize the
exports
field of the package.json file. This came with a change in therequire.resolve
function which automatically tried to resolve the default export of package.json, preventing us to actually get the path to thepackage.json
file. For more information see here.The package
resolve-package-path
simulates the node.js package resolving algorithm and prevents theFailed to resolve module
warning to appear which confuses a lot of developers (see #11822 for example).How to test
theia build
commandFailed to resolve module
warning is printed to the console.Review checklist
Reminder for reviewers