#10028 Support InlineValue feature #11729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndoschek
force-pushed
the
issues/10028
branch
from
d302f5e to
952a0f4
Compare
There was a problem hiding this comment.
Just reading over the code which looks reasonable, for the most part. Regarding testing, could you clarify which versions of the plugin and the readme file the PR should be tested against? The first step says
Install the VSCode extension Mock Debug via the Open VSX registry.
with a link that points not to Open VSX but to the VSCode store. The versions available in the two locations are quite different, and the versions of the model readme file are also quite different.
packages/debug/src/browser/editor/debug-inline-value-decorator.ts
Outdated
Show resolved
Hide resolved
- Implement support for plugins providing inline values Contributed on behalf of STMicroelectronics Signed-off-by: Nina Doschek <[email protected]> Resolves eclipse-theia#10028
|
Thank you @colin-grant-work for your feedback, I updated the testing description - I was not aware of the version differences here. I tested with the latest extension from the marketplace ( |
colin-grant-work
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Contributed on behalf of STMicroelectronics
Signed-off-by: Nina Doschek [email protected]
Resolves #10028
How to test
Mock Debug(current latest version0.51.0) and install via Theia'sExtensionsview (MenuView > Extensions; Toolbar... > Install from VSIX...).readme.mdfile (e.g. the proposedreadme.mdfrom the extension repo)Variablessection will show their values as inline decorations.Review checklist
Reminder for reviewers