[vscode] Support Terminal#creationOptions #11138 #11623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Saves the passed terminal creation options and exposes them via Terminal#creationOptions
Fixes #11138
Contributed on behalf of STMicroelectronics
How to test
I have prepares a small sample extension using the API.
This is available here: https://github.com/jfaltermeier/vscode-playground/releases/download/terminal-creation-options.0.0.5/terminal-creation-options-0.0.5.vsix
Source code: https://github.com/jfaltermeier/vscode-playground/blob/main/terminal-creation-options/src/extension.ts
This extension adds commands to create terminals using the different available
vscode.window.createTerminal
-methods.Also the
creationOptions
of all open terminals may get logged:For regular terminals the
creationOptions
will be written into the newly created terminal.For the pseudo terminal you have to check the logs.
Output of "Print all terminal options" with the three terminals from the extension:
Review checklist
Reminder for reviewers