vscode: Support TreeItemLabel in TreeItem and remove obsolete TreeItem2
#11288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-koehler
force-pushed
the
gh-11148-TreeItemLabel
branch
from
49bc418 to
48b7cd8
Compare
msujew
approved these changes
Jun 13, 2022
* Add `TreeItemLabel` to theia.d.ts * Align `TreeItem.label` with VS Code API to support `TreeItemLabel` as a value * Extend plugin tree view implementation to support showing `TreeItemLabel.highlights` * Extend `TreeViewNode` to also extend `DecoratedTreeNode` * Set highlights in tree node's decoration data to displays them Fixes eclipse-theia#11148 Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
Remove `TreeItem2` and `TreeItemLabel` from proposed plugin api because all properties are now supported and aligned with VS Code by `TreeItem` and `TreeItemLabel` in `theia.d.ts` Contributed on behalf of STMicroelectronics Signed-off-by: Lucas Koehler <[email protected]>
lucas-koehler
force-pushed
the
gh-11148-TreeItemLabel
branch
from
48b7cd8 to
e37a269
Compare
|
Hi @msujew , thanks for the quick review :) I rebased the changes onto master and incorporated your suggestion with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #11148
Support
TreeItemLabelinTreeItemplugin API:TreeItemLabelto theia.d.tsTreeItem.labelwith VS Code API to supportTreeItemLabelas a valueTreeItemLabel.highlightsTreeViewNodeto also extendDecoratedTreeNodeRemove obsolete, proposed
TreeItem2andTreeItemLabel:Remove
TreeItem2andTreeItemLabelfrom proposed plugin api because all properties are now supported and aligned with VS Code byTreeItemandTreeItemLabelintheia.d.ts.Contributed on behalf of STMicroelectronics
Signed-off-by: Lucas Koehler [email protected]
How to test
Review checklist
Reminder for reviewers