Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Decorations]: Emit old and new URI's to ensure ProvideWrapper.data correctly updated #11066

Conversation

colin-grant-work
Copy link
Contributor

What it does

In #10846, I misunderstood the behavior of the DecorationProviderWrapper class and believed that it would respond correctly to a DecorationsProvider emitting only the currently decorated URI's. In fact, it needs to receive a list of both removed and changed URIs.

How to test

  1. Open a file.
  2. Create some problems.
  3. Problem decorations should appear in the file tree.
  4. Save the file.
  5. Git decorations should appear in the file tree. (assuming you're in a tracked repository)
  6. Revert the file to its old state.
  7. The git decorations should disappear from the file tree, and if there are no problems left in the file, the problem decorations should disappear from the file tree.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added the markers issues related to problem markers label Apr 22, 2022
@colin-grant-work colin-grant-work changed the title Emit old and new URI's to ensure ProvideWrapper.data correctly updated [Decorations]: Emit old and new URI's to ensure ProvideWrapper.data correctly updated Apr 22, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes fix the issues present on master where the decorations do not update 👍

@colin-grant-work colin-grant-work added this to the 1.25.0 milestone Apr 22, 2022
@colin-grant-work colin-grant-work merged commit 06b848e into eclipse-theia:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
markers issues related to problem markers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants