Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: align startDebugging api #10656

Merged
merged 1 commit into from
Jan 26, 2022
Merged

plugin: align startDebugging api #10656

merged 1 commit into from
Jan 26, 2022

Conversation

vince-fugnitto
Copy link
Member

What it does

The pull-request includes the following updates:

Aligns startDebugging API

  • updates startDebugging to accept parent DebugSession as a possible option
  • makes parentSessionOrOptions optional

Updates startDebugging to properly respect DebugSessionOptions

How to test

  1. include the following test plugin in the application
  2. start the application using theia as a workspace
  3. open a *.spec.ts file
  4. set breakpoints in the file
  5. execute the command Debug Test: Start (No Config) - confirm that the debug session works
  6. execute the command Debug Test: Start (No Breakpoints) - confirm that the the debug session works (breakpoints are skipped) - Note that due to debug: console is cleared after a debug session #10653 the output of the session is lost when the session is over

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

@vince-fugnitto
plugin: align startDebugging api
057e5dc 
The commit updates the `debug.startDebugging` plugin API with vscode,
namely to accept a parent `DebugSession` as an `otion` and also making
it optional. The commit also fixes an issue where if `options` were
passed to the method the debug session would fail to start.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added vscode issues related to VSCode compatibility debug issues that related to debug functionality labels Jan 20, 2022
@vince-fugnitto vince-fugnitto requested a review from msujew January 20, 2022 14:56
@vince-fugnitto vince-fugnitto self-assigned this Jan 20, 2022
msujew
msujew approved these changes Jan 20, 2022
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! I can confirm that Theia's API now conforms to the API expected by vscode extensions (vscode.d.ts).

  • Both extension commands start debugging as expected
  • Debugging using the debug view continues to work as normal

@msujew msujew mentioned this pull request Jan 24, 2022
Closed
5 tasks
JonasHelming
JonasHelming approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@JonasHelming JonasHelming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vince-fugnitto vince-fugnitto merged commit d38f111 into master Jan 26, 2022
@vince-fugnitto vince-fugnitto deleted the vf/startDebugging branch January 26, 2022 13:40
@github-actions github-actions bot added this to the 1.22.0 milestone Jan 26, 2022
@msujew msujew mentioned this pull request Apr 16, 2022
Closed
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasHelming JonasHelming JonasHelming approved these changes

@msujew msujew msujew approved these changes

Assignees

@vince-fugnitto vince-fugnitto

Labels
debug issues that related to debug functionality vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

plugin: options when calling startDebugging is not supported
3 participants
@vince-fugnitto @JonasHelming @msujew