Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed statusbar foreground color in debug mode #10430

Closed
wants to merge 2 commits into from

Conversation

ChayaLau
Copy link
Contributor

@ChayaLau ChayaLau commented Nov 18, 2021

What it does

Fixed statusbar foreground color in debug mode of color theme

How to test

  1. open a color theme contribution.
  2. set the api of statusbar.debuggingForground to desired color (not black to see difference)
  3. generate a vsix from the extention
  4. install the above vsix in a theia runnable project
  5. click the setting button -> color theme and select the installed theme
  6. run the debug.
    expected results: statusbar foreground color changed as declared
    prev res: statusbar foreground color did not change as declared

Review checklist

Reminder for reviewers

Comment on lines +96 to +98
.theia-mod-debugging #theia-statusBar .area .element {
color: var(--theia-statusBar-debuggingForeground);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChayaLau the idea is good, but the implementation should not be in core but rather debug (as it is debug specific):

/* Status Bar */
.theia-mod-debugging #theia-statusBar {
background: var(--theia-statusBar-debuggingBackground);
color: var(--theia-statusBar-debuggingForeground);
border-top: var(--theia-border-width) solid var(--theia-statusBar-debuggingBorder);
}

@vince-fugnitto vince-fugnitto added debug issues that related to debug functionality theming issues related to theming labels Nov 18, 2021
@JonasHelming
Copy link
Contributor

@ChayaLau Do you plan to adapt your PR according to the feedback?

@msujew
Copy link
Member

msujew commented Feb 14, 2022

@JonasHelming I believe @ChayaLau isn't working on/with Theia anymore, see #10137. Someone else should probably take over this PR if they want it to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debug issues that related to debug functionality theming issues related to theming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants