fix preview of search result

[shuyaqian]

Signed-off-by: shuyaqian [email protected]

What it does

Fix #10045
Fix #7589
Closes #8735

How to test

1. set 'Enable Preview' true in preferences
2. search in workspace
3. click tree item in search results

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[shuyaqian]

I still have some questions I'd like to discuss. If Enable Preview is set to true, whether to open file when double-clicking the file? And if I double-click the preview tab , should block fullscreen events to open this file? @msujew @vince-fugnitto

[msujew]

Hi @shuyaqian thank you for contributing again!

If Enable Preview is set to true, whether to open file when double-clicking the file?

I noticed that someone already tried to fix this in #8735. In there, some discussion on the double clicking behavior already happened. That PR isn't active anymore, so I recommend we should continue discussion on that in here.

The specific double-clicking change in question will be adressed here: #9567. I would argue that we should wait until that is merged to continue the preview related question.

[vince-fugnitto]

I confirmed that it works well for now, when we single-click and editor.enablePreview is enabled we can now open search-in-workspace results in preview-editors. As for the double-click behavior we can do what @msujew mentioned and wait for #9567 first.

[vince-fugnitto]

@shuyaqian do you mind rebasing the pull-request?

[shuyaqian]

@shuyaqian do you mind rebasing the pull-request?

I wonder if I should wait until #9567 be merged before rebase.

[vince-fugnitto]

Thank you for contributing, the pull-request is no longer applicable as the issue was fixed in #10839.