Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theming] color theme should update quick-open fuzzy highlighting #6785

Closed
vince-fugnitto opened this issue Dec 23, 2019 · 1 comment
Closed

[theming] color theme should update quick-open fuzzy highlighting #6785

vince-fugnitto opened this issue Dec 23, 2019 · 1 comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves theming issues related to theming

Comments

@vince-fugnitto
Copy link
Member

Description

The fuzzy highlighting when using the quick-open should be updatable by color themes.
At the moment, they are always blue.

For example: (using the red VS Code theme)

VS Code Theia
image image

Steps to Reproduce

  1. using the PR VS Code like theming (colors and icons) #6475, use the VS Code red theme
  2. open the command palette: ctrlcmd+shift+p
  3. start typing, the fuzzy matches will be in blue
@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves theming issues related to theming labels Dec 23, 2019
@vince-fugnitto
Copy link
Member Author

For reference, the keybindings-widget correctly handles the coloring for fuzzy matches.
It should be easy to update the quick-open to do the same:

image

akosyakov added a commit that referenced this issue Dec 26, 2019
@akosyakov
[theming] fix #6785: align monaco list and scrollbar colors
ea270ba 
Signed-off-by: Anton Kosyakov <[email protected]>
akosyakov added a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
[theming] fix eclipse-theia#6785: align monaco list and scrollbar colors
c195c45 
Signed-off-by: Anton Kosyakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves theming issues related to theming
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vince-fugnitto