Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[electron] JsonRpcProxy#onDidCloseConnection is not invoked when refreshing the browser window #6499

Closed
kittaakos opened this issue Nov 5, 2019 · 0 comments · Fixed by #6681
Closed

[electron] JsonRpcProxy#onDidCloseConnection is not invoked when refreshing the browser window #6499

kittaakos opened this issue Nov 5, 2019 · 0 comments · Fixed by #6681
Labels
bug bugs found in the application electron issues related to the electron target

Comments

@kittaakos
Copy link
Contributor

Description

JsonRpcProxy#onDidCloseConnection is not called on the backend when refreshing the browser window.

This is an electron issue. Works as expected in the browser. Can someone please verify it?
I applied this dummy logging diff:

diff --git a/packages/filesystem/src/node/filesystem-backend-module.ts b/packages/filesystem/src/node/filesystem-backend-module.ts
index 4715f9121..2af378944 100644
--- a/packages/filesystem/src/node/filesystem-backend-module.ts
+++ b/packages/filesystem/src/node/filesystem-backend-module.ts
@@ -67,7 +67,10 @@ export default new ContainerModule(bind => {
         new JsonRpcConnectionHandler<FileSystemClient>(fileSystemPath, client => {
             const dispatching = container.get(DispatchingFileSystemClient);
             dispatching.clients.add(client);
-            client.onDidCloseConnection(() => dispatching.clients.delete(client));
+            client.onDidCloseConnection(() => {
+                console.log('!!!!!!! FSW FileSystemClient#onDidCloseConnection');
+                dispatching.clients.delete(client);
+            });
             return container.get(FileSystem);
         })
     ).inSingletonScope();
@@ -77,7 +80,6 @@ export default new ContainerModule(bind => {
         new JsonRpcConnectionHandler<FileSystemWatcherClient>(fileSystemWatcherPath, client => {
             const server = ctx.container.get<FileSystemWatcherServer>(FileSystemWatcherServer);
             server.setClient(client);
-            client.onDidCloseConnection(() => server.dispose());
             return server;
         })
     ).inSingletonScope();
diff --git a/packages/search-in-workspace/src/node/search-in-workspace-backend-module.ts b/packages/search-in-workspace/src/node/search-in-workspace-backend-module.ts
index 5bea019d7..8c3a0b5d2 100644
--- a/packages/search-in-workspace/src/node/search-in-workspace-backend-module.ts
+++ b/packages/search-in-workspace/src/node/search-in-workspace-backend-module.ts
@@ -27,7 +27,10 @@ export default new ContainerModule(bind => {
             ('/search-in-workspace', client => {
                 const server = ctx.container.get<SearchInWorkspaceServer>(SearchInWorkspaceServer);
                 server.setClient(client);
-                client.onDidCloseConnection(() => server.dispose());
+                client.onDidCloseConnection(() => {
+                    console.log('!!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection');
+                    server.dispose();
+                });
                 return server;
             })
     );

One can see the JsonRpcProxy#onDidCloseConnection was called each time I have refreshed the window with the browser example:

root INFO Detected keyboard layout from browser API: US (Mac)
root INFO Using Git [2.20.1] from the PATH. (/usr/local/bin/git)
root INFO [nsfw-watcher: 16265] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 16265] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 16265] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 480.04999999830034 ms
root INFO [79738ed1-f9e8-4c73-8990-80e31d3fc67e] Sync of 0 plugins took: 91.2300000054529 ms
root INFO [79738ed1-f9e8-4c73-8990-80e31d3fc67e] Load contributions of 0 plugins took: 0.015000005078036338 ms
root INFO [79738ed1-f9e8-4c73-8990-80e31d3fc67e] Start of 0 plugins took: 195.62500000029104 ms
root INFO [79738ed1-f9e8-4c73-8990-80e31d3fc67e] Sync of 0 plugins took: 23.099999998521525 ms
root INFO [79738ed1-f9e8-4c73-8990-80e31d3fc67e] Load contributions of 0 plugins took: 0.014999997802078724 ms
root INFO [79738ed1-f9e8-4c73-8990-80e31d3fc67e] Start of 0 plugins took: 50.53999999654479 ms
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO Detected keyboard layout from browser API: US (Mac)
root INFO [nsfw-watcher: 16276] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 16276] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 16276] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 391.685000002326 ms
root INFO [53ed7365-aabe-40e5-936d-af0f0fa806cf] Sync of 0 plugins took: 53.905000000668224 ms
root INFO [53ed7365-aabe-40e5-936d-af0f0fa806cf] Load contributions of 0 plugins took: 0.010000003385357559 ms
root INFO [53ed7365-aabe-40e5-936d-af0f0fa806cf] Start of 0 plugins took: 146.15500000218162 ms
root INFO [53ed7365-aabe-40e5-936d-af0f0fa806cf] Sync of 0 plugins took: 5.379999995057005 ms
root INFO [53ed7365-aabe-40e5-936d-af0f0fa806cf] Load contributions of 0 plugins took: 0.010000003385357559 ms
root INFO [53ed7365-aabe-40e5-936d-af0f0fa806cf] Start of 0 plugins took: 45.46000000118511 ms
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO Detected keyboard layout from browser API: US (Mac)
root INFO [nsfw-watcher: 16282] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 16282] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 16282] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 395.57999999669846 ms
root INFO [a6e1cbae-57a2-4ee2-b911-fa2b9995736a] Sync of 0 plugins took: 49.27000000316184 ms
root INFO [a6e1cbae-57a2-4ee2-b911-fa2b9995736a] Load contributions of 0 plugins took: 0.014999997802078724 ms
root INFO [a6e1cbae-57a2-4ee2-b911-fa2b9995736a] Start of 0 plugins took: 160.0449999968987 ms
root INFO [a6e1cbae-57a2-4ee2-b911-fa2b9995736a] Sync of 0 plugins took: 2.9749999957857653 ms
root INFO [a6e1cbae-57a2-4ee2-b911-fa2b9995736a] Load contributions of 0 plugins took: 0.005000001692678779 ms
root INFO [a6e1cbae-57a2-4ee2-b911-fa2b9995736a] Start of 0 plugins took: 33.184999992954545 ms
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO Detected keyboard layout from browser API: US (Mac)
root INFO [nsfw-watcher: 16290] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 16290] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 16290] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 409.285000001546 ms
root INFO [f4ea1871-9a6f-4532-b1c3-87ead23099cc] Sync of 0 plugins took: 141.68500000232598 ms
root INFO [f4ea1871-9a6f-4532-b1c3-87ead23099cc] Load contributions of 0 plugins took: 0.010000003385357559 ms
root INFO [f4ea1871-9a6f-4532-b1c3-87ead23099cc] Start of 0 plugins took: 105.80500000651227 ms
root INFO [f4ea1871-9a6f-4532-b1c3-87ead23099cc] Sync of 0 plugins took: 2.529999997932464 ms
root INFO [f4ea1871-9a6f-4532-b1c3-87ead23099cc] Load contributions of 0 plugins took: 0.010000003385357559 ms
root INFO [f4ea1871-9a6f-4532-b1c3-87ead23099cc] Start of 0 plugins took: 22.660000002360903 ms

When I did the same with the electron example, I received the events only when I terminated the backend from the terminal with Ctrl+C (on macOS).

root WARN The directory referenced by local-dir:../../plugins does not exist.
root INFO Theia app listening on http://localhost:59750.
root INFO Git askpass helper is listening on http://127.0.0.1:59753.
root INFO Using Git [2.20.1] from the PATH. (/usr/local/bin/git)
root INFO [nsfw-watcher: 9217] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 9217] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 9217] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 388.200000001234 ms
root INFO [06988c7d-897b-4b46-ab92-7071b8b68b2f] Sync of 0 plugins took: 207.60000000154832 ms
root INFO [06988c7d-897b-4b46-ab92-7071b8b68b2f] Load contributions of 0 plugins took: 0 ms
root INFO [06988c7d-897b-4b46-ab92-7071b8b68b2f] Start of 0 plugins took: 129.89999999990687 ms
root INFO [nsfw-watcher: 9217] Started watching: /Users/akos.kitta/Documents/Arduino/sketch_october25b/sketch_october25b.arduino.avr.uno.elf
root INFO [06988c7d-897b-4b46-ab92-7071b8b68b2f] Sync of 0 plugins took: 23.199999995995313 ms
root INFO [06988c7d-897b-4b46-ab92-7071b8b68b2f] Load contributions of 0 plugins took: 0 ms
root INFO [06988c7d-897b-4b46-ab92-7071b8b68b2f] Start of 0 plugins took: 52.700000000186265 ms
root INFO [nsfw-watcher: 9229] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 9229] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 9229] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 350.69999999541324 ms
root INFO [ef16c782-f288-4aa2-8222-d738c60f108c] Sync of 0 plugins took: 171.39999999926658 ms
root INFO [ef16c782-f288-4aa2-8222-d738c60f108c] Load contributions of 0 plugins took: 0 ms
root INFO [ef16c782-f288-4aa2-8222-d738c60f108c] Start of 0 plugins took: 96.79999999934807 ms
root INFO [ef16c782-f288-4aa2-8222-d738c60f108c] Sync of 0 plugins took: 2.2000000026309863 ms
root INFO [nsfw-watcher: 9229] Started watching: /Users/akos.kitta/Documents/Arduino/sketch_october25b/sketch_october25b.arduino.avr.uno.elf
root INFO [ef16c782-f288-4aa2-8222-d738c60f108c] Load contributions of 0 plugins took: 0 ms
root INFO [ef16c782-f288-4aa2-8222-d738c60f108c] Start of 0 plugins took: 56.29999999655411 ms
root INFO [nsfw-watcher: 9234] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 9234] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 9234] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 361.29999999684514 ms
root INFO [c35e5c5b-5c95-4b1b-be52-e073071c4721] Sync of 0 plugins took: 196.300000003248 ms
root INFO [c35e5c5b-5c95-4b1b-be52-e073071c4721] Load contributions of 0 plugins took: 0 ms
root INFO [c35e5c5b-5c95-4b1b-be52-e073071c4721] Start of 0 plugins took: 111.80000000604196 ms
root INFO [nsfw-watcher: 9234] Started watching: /Users/akos.kitta/Documents/Arduino/sketch_october25b/sketch_october25b.arduino.avr.uno.elf
root INFO [c35e5c5b-5c95-4b1b-be52-e073071c4721] Sync of 0 plugins took: 65.60000000172295 ms
root INFO [c35e5c5b-5c95-4b1b-be52-e073071c4721] Load contributions of 0 plugins took: 0 ms
root INFO [c35e5c5b-5c95-4b1b-be52-e073071c4721] Start of 0 plugins took: 33.19999999803258 ms
root INFO [nsfw-watcher: 9243] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 9243] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 9243] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 361.6000000038184 ms
root INFO [d6ee152c-17e6-4ad5-b522-237bd6848420] Sync of 0 plugins took: 170.6999999951222 ms
root INFO [d6ee152c-17e6-4ad5-b522-237bd6848420] Load contributions of 0 plugins took: 0 ms
root INFO [d6ee152c-17e6-4ad5-b522-237bd6848420] Start of 0 plugins took: 102.50000000087311 ms
root INFO [d6ee152c-17e6-4ad5-b522-237bd6848420] Sync of 0 plugins took: 87.10000000428408 ms
root INFO [nsfw-watcher: 9243] Started watching: /Users/akos.kitta/Documents/Arduino/sketch_october25b/sketch_october25b.arduino.avr.uno.elf
root INFO [d6ee152c-17e6-4ad5-b522-237bd6848420] Load contributions of 0 plugins took: 0 ms
root INFO [d6ee152c-17e6-4ad5-b522-237bd6848420] Start of 0 plugins took: 18.199999998614658 ms
root INFO [nsfw-watcher: 9252] Started watching: /Users/akos.kitta/.theia
root INFO [nsfw-watcher: 9252] Started watching: /Users/akos.kitta/Documents/Arduino
root INFO [nsfw-watcher: 9252] Started watching: /Users/akos.kitta/Documents/Arduino
root WARN EditorNavigationContribution.onStart is slow, took: 367.10000000311993 ms
root INFO [7fdea647-3f27-4c2b-a27e-51a71cd49e7e] Sync of 0 plugins took: 191.40000000334112 ms
root INFO [7fdea647-3f27-4c2b-a27e-51a71cd49e7e] Load contributions of 0 plugins took: 0 ms
root INFO [7fdea647-3f27-4c2b-a27e-51a71cd49e7e] Start of 0 plugins took: 110.00000000058208 ms
root INFO [7fdea647-3f27-4c2b-a27e-51a71cd49e7e] Sync of 0 plugins took: 6.699999998090789 ms
root INFO [nsfw-watcher: 9252] Started watching: /Users/akos.kitta/Documents/Arduino/sketch_october25b/sketch_october25b.arduino.avr.uno.elf
root INFO [7fdea647-3f27-4c2b-a27e-51a71cd49e7e] Load contributions of 0 plugins took: 0 ms
root INFO [7fdea647-3f27-4c2b-a27e-51a71cd49e7e] Start of 0 plugins took: 65.0000000023283 ms
^C
akos.kitta@Akoss-MacBook-Pro theia % root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection
root INFO !!!!!!! FSW FileSystemClient#onDidCloseConnection
root INFO !!!!!!! SIW SearchInWorkspaceClient#onDidCloseConnection

akos.kitta@Akoss-MacBook-Pro theia %

I am looking into it. If you know what could cause this, please let me know.

Reproduction Steps

OS and Theia version:

Diagnostics:
@kittaakos kittaakos added bug bugs found in the application electron issues related to the electron target labels Nov 5, 2019
@kittaakos kittaakos mentioned this issue Nov 12, 2019
Closed
kittaakos pushed a commit that referenced this issue Dec 2, 2019
GH-6499: Explicitly close the socket onStop.
d7b832f 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: #6499
Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Dec 3, 2019
GH-6499: Explicitly close the socket onStop in electron
ab990aa 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: #6499

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Dec 3, 2019
Merged
1 task
kittaakos pushed a commit that referenced this issue Dec 4, 2019
@kittaakos
GH-6499: Explicitly close the socket onStop in electron
d5c8110 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: #6499

Signed-off-by: Akos Kitta <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
f68106e 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
arekzaluski pushed a commit to ARMmbed/theia that referenced this issue Apr 24, 2020
@arekzaluski
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
8c21772 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
arekzaluski pushed a commit to ARMmbed/theia that referenced this issue Apr 28, 2020
@arekzaluski
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
8c98cbb 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos mentioned this issue Jun 12, 2020
Merged
1 task
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
1a2cc44 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
7e340e2 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
055f573 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
2165751 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
e720989 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
073ac8c 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 4, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
576c9a1 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 9, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
e9ff504 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 9, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
01a0c42 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 9, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
7313a82 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 9, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
e8a69df 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 9, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
b62d646 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
f1bdbdc 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
d08e160 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
1271a35 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
c14aaed 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
ac83e5f 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
92916cc 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
65e4415 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 10, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
ad7c394 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
e05b93b 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
e728f7f 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
f15f514 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
f63dec2 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
9e470b4 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
01ab7d9 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 11, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
bed6b66 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
563461d 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
505aed2 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
be89258 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
3534f3e 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
02dca8f 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
a625438 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 12, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
1136462 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 16, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
1fb3c72 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 16, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
69c475d 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 19, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
efce1cc 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
westbury pushed a commit to ARMmbed/theia that referenced this issue Jul 19, 2020
@westbury
eclipse-theiaGH-6499: Explicitly close the socket onStop in electron
84139e2 
Otherwise, the channels will be closed with a `checkAliveTimeout` delay
in the electron application, when refreshing the browser window.

Closes: eclipse-theia#6499

Signed-off-by: Akos Kitta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application electron issues related to the electron target
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-6499: Explicitly close the socket onStop in electron eclipse-theia/theia
1 participant
@kittaakos