Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[search-in-workspace] 'Clear Search Results' still highlights last result #6498

Closed
ericschmidt14 opened this issue Nov 5, 2019 · 2 comments
Closed

[search-in-workspace] 'Clear Search Results' still highlights last result #6498

ericschmidt14 opened this issue Nov 5, 2019 · 2 comments
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help search in workspace issues related to the search-in-workspace

Comments

@ericschmidt14
Copy link
Contributor

ericschmidt14 commented Nov 5, 2019 •
edited
Loading

Description

When clicking 'Clear Search Results' in the search-in-workspace widget of Theia, the last result remains highlighted in the editor. By clearing the search input manually, the same behavior occurs. I would expect, that the decoration of the code editor disappears like e.g. in VS Code.

clear

Reproduction Steps

  • Open a workspace
  • Press Ctrl + Shift + F
  • Search for anything
  • Click on a file in the result tree
  • Press Clear Search Results

Additional Information:

  • Theia: latest
  • OS: Windows 10
  • Browser: Google Chrome 77.0.3865.90
@akosyakov akosyakov added bug bugs found in the application help wanted issues meant to be picked up, require help search in workspace issues related to the search-in-workspace labels Nov 6, 2019
@ericschmidt14
Copy link
Contributor Author

I patched this issue in updateCurrentEditorDecorations() of search-in-workspace-result-tree-widget.tsx. The decorations are only updated, if any file nodes are found, which is not the case when the search term is cleared. I will fix this and contribute.

@akosyakov
Copy link
Member

@ericschmidt14 feel free to open a PR 🙏

ericschmidt14 pushed a commit to siemens/theia that referenced this issue Nov 7, 2019
update decorations when clearing search fix eclipse-theia#6498
d262cfb
@ericschmidt14 ericschmidt14 mentioned this issue Nov 7, 2019
Merged
1 task
ericschmidt14 pushed a commit to siemens/theia that referenced this issue Nov 7, 2019
Update decorations when clearing search fix eclipse-theia#6498 Signed…
e3012cb 
…-off-by: Eric Schmidt <[email protected]>
ericschmidt14 pushed a commit to siemens/theia that referenced this issue Nov 7, 2019
Update decorations when clearing search fix eclipse-theia#6498
c134db9 
Signed-off-by: Eric Schmidt <[email protected]>
ericschmidt14 pushed a commit to siemens/theia that referenced this issue Nov 7, 2019
Update decorations when clearing search fix eclipse-theia#6498
3fbfd66 
Signed-off-by: Eric Schmidt <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@akosyakov
Update decorations when clearing search fix eclipse-theia#6498
85d7ab0 
Signed-off-by: Eric Schmidt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application help wanted issues meant to be picked up, require help search in workspace issues related to the search-in-workspace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akosyakov @ericschmidt14