Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CallHierarchyService Plugin API #3765

Closed
tsmaeder opened this issue Dec 6, 2018 · 5 comments
Closed

CallHierarchyService Plugin API #3765

tsmaeder opened this issue Dec 6, 2018 · 5 comments
Assignees
@vrubezhny
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Dec 6, 2018

Theia has a widget that shows the call hierarchy of a methods. Currently, there is a single implementation for Typescript. In order to convert Typescript support to a plugin, we'll need to add a plugin API for call hierarchy.
IMO, the API should be:

theia.languages.registerCallHierarchyProvider(selector: DocumentSelector, provider: CallHierarchyProvider): Disposable;

CallHierarchyProvider would be based on the interface CallHierarchyService in the callhierarchy pacakge.
@tsmaeder tsmaeder added the languages issue related to languages label Dec 6, 2018
@benoitf
Copy link
Contributor

benoitf commented Dec 6, 2018

some external links as well (to check also what will be vscode API)
microsoft/vscode-languageserver-node#346 (comment)
microsoft/vscode-languageserver-node#420 (comment)

This was referenced Dec 6, 2018
Closed
Closed
@tolusha tolusha added the plug-in system issues related to the plug-in system label Dec 17, 2018
@tsmaeder tsmaeder mentioned this issue Jan 8, 2019
Closed
16 tasks
@tsmaeder tsmaeder mentioned this issue Jan 15, 2019
Closed
30 tasks
@vrubezhny vrubezhny mentioned this issue Jan 22, 2019
Closed
@tsmaeder tsmaeder mentioned this issue Feb 8, 2019
Closed
20 tasks
@tsmaeder tsmaeder mentioned this issue Dec 16, 2019
Closed
28 tasks
@tsmaeder tsmaeder mentioned this issue Jan 8, 2020
Closed
35 tasks
@svor svor mentioned this issue Jan 11, 2020
Closed
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 20, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
013a6ac 
Issue eclipse-theia#3765

Signed-off-by: Thomas MÃder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 20, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
3f35234 
Issue eclipse-theia#3765

Signed-off-by: Thomas MÃder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 21, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
3eee615 
Issue eclipse-theia#3765

Signed-off-by: Thomas MÃder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 21, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
615f7c8 
Issue eclipse-theia#3765

Signed-off-by: Thomas MÃder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 21, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
62ce8d6 
Issue eclipse-theia#3765

Signed-off-by: Thomas MÃder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 21, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
be160da 
Issue eclipse-theia#3765

Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 21, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
06c4218 
Issue eclipse-theia#3765

Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Victor Rubezhny <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 21, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
b2cba28 
Issue eclipse-theia#3765

Signed-off-by: Victor Rubezhny <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 24, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
bdf135f 
Issue eclipse-theia#3765

Signed-off-by: Victor Rubezhny <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder pushed a commit to tsmaeder/theia that referenced this issue Jan 28, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API eclipse-theia#3765
a982e56 
Issue eclipse-theia#3765

Signed-off-by: Victor Rubezhny <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder pushed a commit that referenced this issue Jan 29, 2020
@vrubezhny @tsmaeder
CallHierarchyService Plugin API #3765
764b740 
Issue #3765

Signed-off-by: Victor Rubezhny <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
akosyakov pushed a commit to akosyakov/theia that referenced this issue Feb 24, 2020
@vrubezhny @akosyakov
CallHierarchyService Plugin API eclipse-theia#3765
4615430 
Issue eclipse-theia#3765

Signed-off-by: Victor Rubezhny <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
JesterOrNot pushed a commit to JesterOrNot/theia that referenced this issue Mar 12, 2020
@vrubezhny
CallHierarchyService Plugin API eclipse-theia#3765
ac3b21d 
Issue eclipse-theia#3765

Signed-off-by: Victor Rubezhny <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder added vscode issues related to VSCode compatibility and removed languages issue related to languages labels May 7, 2021
@JonasHelming
Copy link
Contributor

@tsmaeder : It seems the PRs are closed, can we also cllose this issue?

@tsmaeder
Copy link
Contributor Author

No, we've only implemented the "incoming calls" part ("callers"). We're missing the "outgoing calls" part ("callees"). See https://code.visualstudio.com/api/references/vscode-api#CallHierarchyProvider

@JonasHelming
Copy link
Contributor

@tsmaeder According to the report https://eclipse-theia.github.io/vscode-theia-comparator/status.html
CallHierarchy provider is implemented. Is there something still missing?

@tsmaeder
Copy link
Contributor Author

Methinks @colin-grant-work has added the rest in this PR: https://github.com/eclipse-theia/theia/pull/9681/files. Good to close, afaic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrubezhny vrubezhny

Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benoitf @vrubezhny @JonasHelming @tolusha @tsmaeder