Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[textmate] remove C# #2555

Closed
svenefftinge opened this issue Aug 11, 2018 · 2 comments
Closed

[textmate] remove C# #2555

svenefftinge opened this issue Aug 11, 2018 · 2 comments
Assignees
@svenefftinge
Labels
textmate issues related to the textmate grammars
Milestone
August 2018

Comments

@svenefftinge
Copy link
Contributor

We now have an extension, so the language definition and grammars are coming from there.

https://github.com/theia-ide/theia-csharp-extension
@svenefftinge svenefftinge added this to the August 2018 milestone Aug 11, 2018
@svenefftinge svenefftinge self-assigned this Aug 11, 2018
svenefftinge added a commit that referenced this issue Aug 11, 2018
@svenefftinge
[textmate] Removed csharp grammar and def
c0d8b3a 
Fixes #2555
@svenefftinge svenefftinge mentioned this issue Aug 11, 2018
Merged
svenefftinge added a commit that referenced this issue Aug 11, 2018
@svenefftinge
[textmate] Removed csharp grammar and def
3acb92d 
Fixes #2555

Signed-off-by: Sven Efftinge <[email protected]>
svenefftinge added a commit that referenced this issue Aug 15, 2018
@svenefftinge
[textmate] Removed csharp grammar and def
a5a2374 
Fixes #2555

Signed-off-by: Sven Efftinge <[email protected]>
jbicker pushed a commit that referenced this issue Aug 16, 2018
@svenefftinge @jbicker
[textmate] Removed csharp grammar and def
f41eded 
Fixes #2555

Signed-off-by: Sven Efftinge <[email protected]>
@svenefftinge svenefftinge reopened this Aug 17, 2018
marcdumais-work pushed a commit to marcdumais-work/theia that referenced this issue Oct 15, 2018
@svenefftinge @marcdumais-work
[textmate] Removed csharp grammar and def
6e1f69f 
Fixes eclipse-theia#2555

Signed-off-by: Sven Efftinge <[email protected]>
@vince-fugnitto
Copy link
Member

We now have the csharp builtin providing syntax highlighting and textmate-grammars will be deprecated as of #6933. I'll close this issue once it is merged.

@vince-fugnitto vince-fugnitto added the textmate issues related to the textmate grammars label Jan 30, 2020
@vince-fugnitto
Copy link
Member

Closing thanks to #6933.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svenefftinge svenefftinge

Labels
textmate issues related to the textmate grammars
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
2 participants
@svenefftinge @vince-fugnitto