Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clojure syntax highlighter #1717

Closed
avelino opened this issue Apr 17, 2018 · 9 comments
Closed

Clojure syntax highlighter #1717

avelino opened this issue Apr 17, 2018 · 9 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves languages issue related to languages

Comments

@avelino
Copy link

avelino commented Apr 17, 2018

screenshot 2018-04-17 10 58 19

@kittaakos kittaakos added enhancement issues that are enhancements to current functionality - nice to haves lsp language server protocol and removed lsp language server protocol labels Apr 18, 2018
@kittaakos
Copy link
Contributor

I am not aware of any Theia Clojure extension. Without that, you will get neither syntax coloring, nor LS support. @akosyakov, do we have support for Clojure?

@akosyakov
Copy link
Member

We have coloring for languages from monaco-languages: https://github.com/Microsoft/monaco-languages/tree/master/src It does not seem to be there. You are welcome to open a PR there or create a Theia extension.

@svenefftinge
Copy link
Contributor

Also there is https://github.com/snoe/clojure-lsp

@avelino
Copy link
Author

avelino commented May 31, 2018

@kittaakos now the monaco-languages is supported Clojure, should be updated something in this repository?
refs:
microsoft/monaco-languages#36
microsoft/monaco-editor#828 (comment)

@marcdumais-work
Copy link
Contributor

@avelino I think we have a plan to upgrade to the latest monaco, sometime in the next month or two. Assuming this support is released by then, we should pick it up.

@avelino
Copy link
Author

avelino commented Mar 4, 2019

Almost 1 year was accepted the PR, was updated the monaco-editor in Theia-IDE?

@akosyakov
Copy link
Member

akosyakov commented Mar 4, 2019

We don't use monaco-languages, but textmate grammars. There is already textmate grammar for clojure: https://github.com/theia-ide/theia/blob/master/packages/textmate-grammars/src/browser/clojure.ts It should work out of the box already.

@vince-fugnitto
Copy link
Member

vince-fugnitto commented Jan 16, 2020

Clojure syntax highlighting is now contributed by vscode-builtin-clojure (related PR #6883). Note, @theia/textmate-grammars is soon to be deprecated.

@akosyakov akosyakov added the languages issue related to languages label Jan 17, 2020
@vince-fugnitto
Copy link
Member

Closed by #6883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves languages issue related to languages
Projects
None yet
Development

No branches or pull requests

6 participants