Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat Input is unusable #14924

Closed
Tracked by #14923
, #462
...
sdirix opened this issue Feb 14, 2025 · 3 comments · Fixed by #14942
Closed
Tracked by #14923
, #462
...

Chat Input is unusable #14924

sdirix opened this issue Feb 14, 2025 · 3 comments · Fixed by #14942
Labels
bug bugs found in the application TheiaAI

Comments

@sdirix
Copy link
Member

sdirix commented Feb 14, 2025

Bug Description:

The chat input grows indefinitely and is unusable

Image

Steps to Reproduce:

  1. Open the Chat View

Additional Information

Seems to be caused by #14909

  • Operating System: Ubuntu 22.04
  • Theia Version: latest master 9944d0e
@sdirix sdirix added the TheiaAI label Feb 14, 2025
@sdirix sdirix mentioned this issue Feb 14, 2025
Closed
25 tasks
@sdirix sdirix added the bug bugs found in the application label Feb 14, 2025
@tsmaeder
Copy link
Contributor

To me, it seems that the ChatInput component adds a resize listener to the editor and in that listener, it sets the size of the editor again. This leads to an infinite loop if the size we're setting does not converge on a constant value.

@tsmaeder
Copy link
Contributor

Although: I can't get a breakpoint in the updating code to ever hit. Maybe something else is going on here.

@sdirix
Copy link
Member Author

sdirix commented Feb 17, 2025 •
edited
Loading

Might be useful hint: When reverting 72ca8ed, then updateEditorHeight is hit, so there seems to be a behavior change with onDidModelChangeContent.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Feb 17, 2025
@tsmaeder
Do not create a model reference for inline editors
908e1fb 
Fixes eclipse-theia#14924

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
This was referenced Feb 17, 2025
Merged
Closed
tsmaeder added a commit that referenced this issue Feb 17, 2025
@tsmaeder
Do not create a model reference for inline editors (#14942)
0419c0a 
Fixes #14924

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder added a commit that referenced this issue Feb 17, 2025
@tsmaeder
Do not create a model reference for inline editors (#14942)
4af367c 
Fixes #14924

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@msujew msujew mentioned this issue Feb 18, 2025
Merged
1 task
@JonasHelming JonasHelming mentioned this issue Feb 26, 2025
Open
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug bugs found in the application TheiaAI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not create a model reference for inline editors tsmaeder/theia
2 participants
@sdirix @tsmaeder