Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AIEditorManager #14873

Closed
Tracked by #14143
sdirix opened this issue Feb 7, 2025 · 0 comments · Fixed by #14912
Closed
Tracked by #14143

Remove AIEditorManager #14873

sdirix opened this issue Feb 7, 2025 · 0 comments · Fixed by #14912
Labels
TheiaAI

Comments

@sdirix
Copy link
Member

sdirix commented Feb 7, 2025 •
edited
Loading

The original contribution customizes the EditorManager in the AIEditorManager and rebinds it. This is problematic for downstream projects which also rebind the EditorManager. The editor manager enhancements should be merged into the base implementation instead.
@sdirix sdirix mentioned this issue Feb 7, 2025
Open
25 tasks
@sdirix sdirix changed the title The original contribution customizes the EditorManager in the AIEditorManager and rebinds it. [This is problematic for downstream projects which also rebind the EditorManager](https://github.com/eclipse-theia/theia/pull/14048#discussion_r1734227614). The editor manager enhancements should be merged into the base implementation instead. Remove AIEditorManager Feb 7, 2025
@sdirix sdirix added the TheiaAI label Feb 7, 2025
eneufeld added a commit to eclipsesource/theia that referenced this issue Feb 13, 2025
@eneufeld
Remove AIEditorManager
1b61557 
fixes eclipse-theia#14873

- move the customizations to the parent class EditorPreviewManager
- rename AIEditorSelectionResolver and move it to editor-preview-manager.ts
@eneufeld eneufeld mentioned this issue Feb 13, 2025
Merged
2 tasks
eneufeld added a commit to eclipsesource/theia that referenced this issue Feb 14, 2025
@eneufeld
Remove AIEditorManager
9e09f55 
fixes eclipse-theia#14873

- move the customizations to the parent class EditorPreviewManager
- rename AIEditorSelectionResolver and move it to editor-preview-manager.ts
eneufeld added a commit to eclipsesource/theia that referenced this issue Feb 14, 2025
@eneufeld
Remove AIEditorManager
23999ad 
fixes eclipse-theia#14873

- move the customizations to the parent class EditorPreviewManager
- rename AIEditorSelectionResolver and move it to editor-preview-manager.ts
@JonasHelming JonasHelming mentioned this issue Feb 14, 2025
Closed
25 tasks
sdirix pushed a commit to eclipsesource/theia that referenced this issue Feb 19, 2025
@eneufeld @sdirix
Remove AIEditorManager
1d8a7fe 
fixes eclipse-theia#14873

- move the customizations to the parent class EditorPreviewManager
- rename AIEditorSelectionResolver and move it to editor-preview-manager.ts
sdirix pushed a commit to eclipsesource/theia that referenced this issue Feb 19, 2025
@eneufeld @sdirix
Remove AIEditorManager
a6b0448 
fixes eclipse-theia#14873

- move the customizations to the parent class EditorPreviewManager
- rename AIEditorSelectionResolver and move it to editor-preview-manager.ts
sdirix added a commit that referenced this issue Feb 20, 2025
@eneufeld @sdirix
chore: remove AIEditorManager (#14912)
164c226 
fixes #14873

- move the customizations to the parent class EditorManager
- rename AIEditorSelectionResolver and move it to editor-manager.ts

Co-authored-by: Stefan Dirix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TheiaAI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove AIEditorManager eclipsesource/theia
1 participant
@sdirix