Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TheiaBlueprint 1.44.0 cannot quit app when there is a dirty editor #13164

Closed
Tracked by #13192
kittaakos opened this issue Dec 11, 2023 · 0 comments
Closed
Tracked by #13192

TheiaBlueprint 1.44.0 cannot quit app when there is a dirty editor #13164

kittaakos opened this issue Dec 11, 2023 · 0 comments

Comments

@kittaakos
Copy link
Contributor

Bug Description:

When I want to quit the Theia Blueprint app when I have a dirty editor, the app never quits when I decide to not save the file changes

Steps to Reproduce:

  1. Open Theia Blueprint,
  2. Disable auto-save,
  3. Create a new file,
  4. Make the editor dirty,
  5. Quit Theia,
  6. Click don't save when prompted, the app does not quit.
cannot_quit_app_with_dirty_editor.mp4

Expected behavior:

  • The app quits and I lose my unsaved changes

Additional Information

  • Operating System: macOS
  • Theia Version: 1.44
@JonasHelming JonasHelming mentioned this issue Dec 12, 2023
Open
4 tasks
emilhammarstedtst added a commit to emilhammarstedtst/theia that referenced this issue Dec 13, 2023
@emilhammarstedtst
fix: Cannot quit app when there is a dirty editor (eclipse-theia#13164)
3629429 
Contributed by STMicroelectronics

Signed-off-by: Emil HAMMARSTEDT <[email protected]>
@emilhammarstedtst emilhammarstedtst mentioned this issue Dec 13, 2023
Merged
1 task
emilhammarstedtst added a commit to emilhammarstedtst/theia that referenced this issue Dec 13, 2023
@emilhammarstedtst
fix: Cannot quit app when there is a dirty editor (eclipse-theia#13164)
1482909 
Contributed by STMicroelectronics

Signed-off-by: Emil HAMMARSTEDT <[email protected]>
emilhammarstedtst added a commit to emilhammarstedtst/theia that referenced this issue Dec 13, 2023
@emilhammarstedtst
fix: Cannot quit app when there is a dirty editor (eclipse-theia#13164)
2b8ed54 
Contributed by STMicroelectronics

Signed-off-by: Emil HAMMARSTEDT <[email protected]>
emilhammarstedtst added a commit to emilhammarstedtst/theia that referenced this issue Dec 18, 2023
@emilhammarstedtst
fix: Cannot quit app when there is a dirty editor (eclipse-theia#13164)
e900e2f 
Contributed by STMicroelectronics

Signed-off-by: Emil HAMMARSTEDT <[email protected]>
tsmaeder pushed a commit that referenced this issue Dec 19, 2023
@emilhammarstedtst
fix: Cannot quit app when there is a dirty editor (#13164) (#13173)
d0a09a9 
Contributed by STMicroelectronics

Signed-off-by: Emil HAMMARSTEDT <[email protected]>
@JonasHelming JonasHelming mentioned this issue Dec 19, 2023
Open
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittaakos @tsmaeder