-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode formatter settings are not correctly used in multi root workspaces #13108
Closed
Tracked by
#13192
Milestone
Comments
4 tasks
I can take a look! |
sgraband
added a commit
to eclipsesource/theia
that referenced
this issue
Jan 17, 2024
This way the default formatter will be resolved correctly in multi-root workspaces. Beforehand only the workspace settings where taken into account. Now the behavior is as expected, see eclipse-theia#13108 for an example. Fixes eclipse-theia#13108. Contributed on behalf of STMicroelectronics
1 task
sgraband
added a commit
to eclipsesource/theia
that referenced
this issue
Jan 17, 2024
This way the default formatter will be resolved correctly in multi-root workspaces. Beforehand only the workspace settings where taken into account. Now the behavior is as expected, see eclipse-theia#13108 for an example. Fixes eclipse-theia#13108. Contributed on behalf of STMicroelectronics
sgraband
added a commit
to eclipsesource/theia
that referenced
this issue
Jan 25, 2024
This way the default formatter will be resolved correctly in multi-root workspaces. Beforehand only the workspace settings where taken into account. Now the behavior is as expected, see eclipse-theia#13108 for an example. Fixes eclipse-theia#13108. Contributed on behalf of STMicroelectronics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description:
Using a multi root workspace where each folder has it's own .vscode folder with a settings.json which defines which formatter to use, is not usable in theia. On the first use of the formatter, Theia asks which formatter to use and stores this data in the workspace file. This does not allow to use different formatters per folder. Furthermore this duplicates information that is already available.
I attached a simple multiroot workspace with a minimal set of dependencies.
As formatter, prettier is used with eslint.
Steps to Reproduce:
Running the same in vscode does not produce the same change and the correct formatter is used directly.
Additional Information
The text was updated successfully, but these errors were encountered: