Apply suggestions from code review

Co-authored-by: Vincent Fugnitto <[email protected]>
eclipse-theia · Oct 30, 2020 · e27f0d4 · e27f0d4
1 parent 203fc7a
commit e27f0d4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/browser/preferences/preference-contribution.ts b/packages/core/src/browser/preferences/preference-contribution.ts
@@ -133,7 +133,7 @@ export class PreferenceSchemaProvider extends PreferenceProvider {
     /**
      * Register a new overrideIdentifier. Existing identifiers are not replaced.
      *
-     * Allows overriding existing values while keeping both values in store
+     * Allows overriding existing values while keeping both values in store.
      * For example to store different editor settings, e.g. "[markdown].editor.autoIndent",
      * "[json].editor.autoIndent" and "editor.autoIndent"
      * @param overrideIdentifier the new overrideIdentifier

diff --git a/packages/core/src/browser/preferences/preference-service.ts b/packages/core/src/browser/preferences/preference-service.ts
@@ -50,7 +50,7 @@ export interface PreferenceChange {
     readonly scope: PreferenceScope;
     /**
      * Tests wether the given resource is affected by the preference change.
-     * @param resourceUri The uri of the resource to test.
+     * @param resourceUri the uri of the resource to test.
      */
     affects(resourceUri?: string): boolean;
 }