MS comments

eclipse-theia · Aug 4, 2022 · d8f1b57 · d8f1b57
1 parent b38aa6f
commit d8f1b57
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 10 deletions.
diff --git a/packages/memory-inspector/src/browser/diff-widget/memory-diff-options-widget.tsx b/packages/memory-inspector/src/browser/diff-widget/memory-diff-options-widget.tsx
@@ -102,17 +102,17 @@ export class MemoryDiffOptionsWidget extends MemoryOptionsWidget {
             <div className='t-mv-group view-group'>
                 <MWInput
                     id={LOCATION_OFFSET_FIELD_ID}
-                    label={`${beforeTitle} Offset`}
-                    title={`Bytes to offset the memory from ${beforeTitle}`}
+                    label={nls.localize('theia/memory-inspector/diff-widget/offset-label', '{0} Offset', beforeTitle)}
+                    title={nls.localize('theia/memory-inspector/diff-widget/offset-title', 'Bytes to offset the memory from {0}', beforeTitle)}
                     defaultValue='0'
                     passRef={this.assignOffsetRef}
                     onChange={Utils.validateNumericalInputs}
                     onKeyDown={this.doRefresh}
                 />
                 <MWInput
                     id={LENGTH_FIELD_ID}
-                    label={`${afterTitle} Offset`}
-                    title={`Bytes to offset the memory from ${afterTitle}`}
+                    label={nls.localize('theia/memory-inspector/diff-widget/offset-label', '{0} Offset', afterTitle)}
+                    title={nls.localize('theia/memory-inspector/diff-widget/offset-title', 'Bytes to offset the memory from {0}', afterTitle)}
                     defaultValue='0'
                     passRef={this.assignReadLengthRef}
                     onChange={Utils.validateNumericalInputs}

diff --git a/packages/memory-inspector/src/browser/diff-widget/memory-diff-select-widget.tsx b/packages/memory-inspector/src/browser/diff-widget/memory-diff-select-widget.tsx
@@ -27,7 +27,7 @@ import { VariableRange } from '../utils/memory-widget-variable-utils';
 import { MemoryDiffWidget } from './memory-diff-table-widget';
 import { nls } from '@theia/core/lib/common/nls';
 
-interface DiffMemory {
+export interface DiffMemory {
     beforeAddress: Long;
     beforeBytes: Interfaces.LabeledUint8Array;
     beforeVariables: VariableRange[];

diff --git a/packages/memory-inspector/src/browser/memory-widget/memory-table-widget.tsx b/packages/memory-inspector/src/browser/memory-widget/memory-table-widget.tsx
@@ -217,7 +217,7 @@ export class MemoryTableWidget extends ReactWidget {
         const rows = this.getTableRows();
         const { onClick, onContextMenu, onFocus, onBlur, onKeyDown, onMouseMove } = this.getWrapperHandlers();
         const headers: Interfaces.ColumnIDs[] = Object.entries(this.options.columnsDisplayed)
-            .filter(([_id, { doRender }]) => doRender)
+            .filter(([, { doRender }]) => doRender)
             .map(([id, { label }]) => ({ label, id }));
 
         return (

diff --git a/packages/memory-inspector/src/browser/register-widget/register-options-widget.tsx b/packages/memory-inspector/src/browser/register-widget/register-options-widget.tsx
@@ -209,8 +209,8 @@ export class RegisterOptionsWidget extends MemoryOptionsWidget {
                 <div className='t-mv-group view-group'>
                     <MWInputWithSelect
                         id={REGISTER_FIELD_ID}
-                        label='Registers'
-                        placeholder='Filter (starts with)'
+                        label={nls.localize('theia/memory-inspector/registers', 'Registers')}
+                        placeholder={nls.localize('theia/memory-inspector/register-widget/filter-placeholder', 'Filter (starts with)')}
                         onSelectChange={this.setRegFilterFromSelect}
                         passRef={this.assignRegisterRef}
                         onKeyDown={this.doRefresh}

diff --git a/packages/memory-inspector/src/browser/register-widget/register-widget-types.ts b/packages/memory-inspector/src/browser/register-widget/register-widget-types.ts
@@ -14,6 +14,7 @@
  * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
  ********************************************************************************/
 
+import { nls } from '@theia/core';
 import { interfaces } from '@theia/core/shared/inversify';
 import { MemoryOptionsWidget } from '../memory-widget/memory-options-widget';
 import { MemoryTableWidget } from '../memory-widget/memory-table-widget';
@@ -26,7 +27,7 @@ import { RegisterTableWidget } from './register-table-widget';
 export type RegisterWidget = MemoryWidget<RegisterOptionsWidget, RegisterTableWidget>;
 export namespace RegisterWidget {
     export const ID = 'register-view-options-widget';
-    export const LABEL = 'Register';
+    export const LABEL = nls.localize('theia/memory-inspector/register', 'Register');
     export const is = (widget: MemoryWidget): boolean => widget.optionsWidget instanceof RegisterOptionsWidget;
 
     export const createContainer = (

diff --git a/packages/memory-inspector/src/browser/utils/memory-widget-manager.ts b/packages/memory-inspector/src/browser/utils/memory-widget-manager.ts
@@ -125,7 +125,7 @@ export class MemoryWidgetManager implements Disposable {
             return undefined;
         } else if (options.afterBytes.length === 0) {
             // eslint-disable-next-line max-len
-            const afterBytesMessage = nls.localize('theia/memory-inspector/utils/afterByes', 'You must load memory in both widgets you would like to compare. {0} has no memory loaded.', options.titles[1]);
+            const afterBytesMessage = nls.localize('theia/memory-inspector/utils/afterBytes', 'You must load memory in both widgets you would like to compare. {0} has no memory loaded.', options.titles[1]);
             this.messageService.warn(afterBytesMessage);
             return undefined;
         }