Null-check call result rather than function itself

From the comment, it seems like this was supposed check for chords, rather than checking for the availability of `isChord`. Signed-off-by: Andrew Casey <[email protected]> Signed-off-by: Paul Maréchal <[email protected]>
eclipse-theia · Apr 1, 2020 · a7c47af · a7c47af
1 parent 9481af8
commit a7c47af
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 19 deletions.
diff --git a/examples/api-tests/src/monaco-api.spec.js b/examples/api-tests/src/monaco-api.spec.js
@@ -65,24 +65,24 @@ describe('Monaco API', async function () {
             assert.deepStrictEqual({
                 label, ariaLabel, electronAccelerator, userSettingsLabel, WYSIWYG, chord, parts, dispatchParts
             }, {
-                    label: "Ctrl+Shift+Alt+K",
-                    ariaLabel: "Ctrl+Shift+Alt+K",
-                    electronAccelerator: null,
-                    userSettingsLabel: "ctrl+shift+alt+K",
-                    WYSIWYG: true,
-                    chord: false,
-                    parts: [{
-                        altKey: true,
-                        ctrlKey: true,
-                        keyAriaLabel: "K",
-                        keyLabel: "K",
-                        metaKey: false,
-                        shiftKey: true
-                    }],
-                    dispatchParts: [
-                        "ctrl+shift+alt+K"
-                    ]
-                });
+                label: "Ctrl+Shift+Alt+K",
+                ariaLabel: "Ctrl+Shift+Alt+K",
+                electronAccelerator: "Ctrl+Shift+Alt+K",
+                userSettingsLabel: "ctrl+shift+alt+K",
+                WYSIWYG: true,
+                chord: false,
+                parts: [{
+                    altKey: true,
+                    ctrlKey: true,
+                    keyAriaLabel: "K",
+                    keyLabel: "K",
+                    metaKey: false,
+                    shiftKey: true
+                }],
+                dispatchParts: [
+                    "ctrl+shift+alt+K"
+                ]
+            });
         } else {
             assert.fail(`resolvedKeybinding must be of ${MonacoResolvedKeybinding.name} type`);
         }

diff --git a/packages/monaco/src/browser/monaco-resolved-keybinding.ts b/packages/monaco/src/browser/monaco-resolved-keybinding.ts
@@ -49,7 +49,7 @@ export class MonacoResolvedKeybinding extends monaco.keybindings.ResolvedKeybind
     }
 
     public getElectronAccelerator(): string | null {
-        if (this.isChord) {
+        if (this.isChord()) {
             // Electron cannot handle chords
             // eslint-disable-next-line no-null/no-null
             return null;