7738-view-data-not-populated:

switching between view containers could cause view not to be populated with data Signed-off-by: Dan Arad <[email protected]>
eclipse-theia · Mar 25, 2021 · 5f57a3e · 5f57a3e
1 parent eb83e0e
commit 5f57a3e
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/plugin-ext/src/main/browser/view/plugin-view-registry.ts b/packages/plugin-ext/src/main/browser/view/plugin-view-registry.ts
@@ -470,15 +470,19 @@ export class PluginViewRegistry implements FrontendApplicationContribution {
                 part.onDidChangeVisibility(() => widget.suppressUpdateViewVisibility = part.isHidden);
 
                 const tryFireOnDidExpandView = () => {
-                    if (!part.collapsed && part.isVisible) {
+                    if (widget.widgets.length === 0) {
+                        if (!part.collapsed && part.isVisible) {
+                            this.onDidExpandViewEmitter.fire(viewId);
+                        }
+                    } else {
                         toFire.dispose();
                     }
                 };
                 const toFire = new DisposableCollection(
-                    Disposable.create(() => this.onDidExpandViewEmitter.fire(viewId)),
                     part.onCollapsed(tryFireOnDidExpandView),
                     part.onDidChangeVisibility(tryFireOnDidExpandView)
                 );
+
                 tryFireOnDidExpandView();
             }
         }