Address review comments

Signed-off-by: Thomas Mäder <[email protected]>
eclipse-theia · Dec 13, 2023 · 4b3e870 · 4b3e870
1 parent 5b8a47c
commit 4b3e870
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 14 deletions.
diff --git a/dev-packages/application-package/src/application-props.ts b/dev-packages/application-package/src/application-props.ts
@@ -149,7 +149,7 @@ export type BackendApplicationConfig = RequiredRecursive<BackendApplicationConfi
 export namespace BackendApplicationConfig {
     export const DEFAULT: BackendApplicationConfig = {
         singleInstance: false,
-        frontendConnectionTimeout: 1000
+        frontendConnectionTimeout: 0
     };
     export interface Partial extends ApplicationConfig {
 

diff --git a/packages/core/src/common/messaging/socket-write-buffer.ts b/packages/core/src/common/messaging/socket-write-buffer.ts
@@ -14,12 +14,7 @@
 // SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
 // *****************************************************************************
 
-/* eslint-disable @typescript-eslint/no-explicit-any */
-
-import { Socket as ClientSocket } from 'socket.io-client';
-import { Socket as ServerSocket } from 'socket.io';
-
-export type WebSocket = ClientSocket | ServerSocket;
+import { WebSocket } from './web-socket-channel';
 
 export class SocketWriteBuffer {
     private static DISCONNECTED_BUFFER_SIZE = 100 * 1024;

diff --git a/packages/core/src/electron-browser/messaging/electron-ipc-connection-source.ts b/packages/core/src/electron-browser/messaging/electron-ipc-connection-source.ts
@@ -16,11 +16,10 @@
 
 import { injectable, interfaces } from 'inversify';
 import { RpcProxy } from '../../common/messaging';
-import { AbstractChannel, Channel, Event, MaybePromise, WriteBuffer } from '../../common';
+import { AbstractChannel, Channel, Emitter, Event, MaybePromise, WriteBuffer } from '../../common';
 import { Uint8ArrayReadBuffer, Uint8ArrayWriteBuffer } from '../../common/message-rpc/uint8-array-message-buffer';
 import { ServiceConnectionProvider } from '../../browser/messaging/service-connection-provider';
 import { ConnectionSource } from '../../browser/messaging/connection-source';
-import { Emitter } from 'vscode-languageserver-protocol';
 import { FrontendApplicationContribution } from '../../browser';
 
 export interface ElectronIpcOptions {

diff --git a/packages/core/src/node/messaging/websocket-frontend-connection-service.ts b/packages/core/src/node/messaging/websocket-frontend-connection-service.ts
@@ -15,7 +15,7 @@
 
 import { Channel, WriteBuffer } from '../../common/message-rpc';
 import { MessagingService } from './messaging-service';
-import { inject, injectable, postConstruct } from 'inversify';
+import { inject, injectable } from 'inversify';
 import { Socket } from 'socket.io';
 import { ConnectionHandlers } from './default-messaging-service';
 import { SocketWriteBuffer } from '../../common/messaging/socket-write-buffer';
@@ -38,10 +38,6 @@ export class WebsocketFrontendConnectionService implements FrontendConnectionSer
     protected readonly closeTimeouts = new Map<string, NodeJS.Timeout>();
     protected readonly channelsMarkedForClose = new Set<string>();
 
-    @postConstruct()
-    init(): void {
-    }
-
     registerConnectionHandler(spec: string, callback: (params: MessagingService.PathParams, channel: Channel) => void): void {
         this.websocketServer.registerConnectionHandler(spec, (params, socket) => this.handleConnection(socket, channel => callback(params, channel)));
     }