Support 'when':'true' in 'commandPalette' menus

Adds a missing check for "true" on contributed "commandPalette" menus Fixes: #9065 Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
eclipse-theia · Mar 22, 2021 · 309fab4 · 309fab4
1 parent 5dc9612
commit 309fab4
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/core/src/browser/quick-open/quick-command-service.ts b/packages/core/src/browser/quick-open/quick-command-service.ts
@@ -191,7 +191,10 @@ export class QuickCommandService implements QuickOpenModel, QuickOpenHandler {
         raw.forEach((command: Command) => {
             if (command.label) {
                 const contexts = this.contexts.get(command.id);
-                if (!contexts || contexts.some(when => this.contextKeyService.match(when))) {
+                if (!contexts || contexts.some(when => {
+                    when = when.trim();
+                    return when === 'true' || this.contextKeyService.match(when);
+                })) {
                     valid.push(command);
                 }
             }