Update Electron App Window Icon on Linux #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* set electron window icon on linux * on windows and mac the executable icon is used as a fallback by default Signed-off-by: Johannes Faltermeier <[email protected]>
marcdumais-work
approved these changes
Nov 24, 2021
There was a problem hiding this comment.
LGTM, thanks @jfaltermeier . I have confirmed it works well - I now see the Blueprint icon on Linux!
theia-extensions/theia-blueprint-product/src/electron-main/icon-contribution.ts
Outdated
Show resolved
Hide resolved
* simplify setting window icon Co-authored-by: Vincent Fugnitto <[email protected]>
|
@vince-fugnitto are you ok with the current state of this PR? If so, can you approve? |
vince-fugnitto
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Set electron window icon on linux programmatically as the executable itself does not have an image.
This is a know issue for AppImage:
https://www.electron.build/configuration/appimage
electron-userland/electron-builder#4617
closes #178
How to test
Build linux installer and check the window icon
Review checklist
Reminder for reviewers