This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
Show variables in memory view #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
force-pushed
the
simark/variables-in-memory-view
branch
2 times, most recently
from
53288a7 to
dbcf20a
Compare
|
Apparently there is a bug where we cannot scroll anymore. |
vince-fugnitto
force-pushed
the
simark/variables-in-memory-view
branch
from
dbcf20a to
efd9b6a
Compare
In theory, we could have problems reading addresses as JS numbers, since JS numbers don't have full 64 bits precision. This patch makes use of the 'long' library, which stores 64-bit numbers as two 32-bit halves. Signed-off-by: Simon Marchi <[email protected]> Signed-off-by: Paul Maréchal <[email protected]>
This patch makes it so we hightlight the local variables of the current frame in the memory view. The idea is simple, we get the size and address of all locals of the current frame through GDB (sizeof(foo) and &foo). If the bytes backing these variables are in the scope of the memory view, we highlight them with a different color for each variable. Signed-off-by: Simon Marchi <[email protected]> Signed-off-by: Paul Maréchal <[email protected]> Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
simark/variables-in-memory-view
branch
from
efd9b6a to
93bee9a
Compare
|
I've rebased the PR on the latest changes, and fixed the issue regarding the scrolling. @marechal-p can you confirm that scrolling works correctly as before? |
|
@marechal-p, @vince-fugnitto, This is a feature our users have been requesting. Is it still planned to merge this PR? |
I believe so, it was forgotten for a while now so I'll rebase it and re-test. |
|
Closing in favor of #111. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #22 by @simark