-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a method to allow LifecycleManager to free keys #75
Conversation
FYI, this is Java 7 project |
FYI even Java 8 is EOL for a long time, so maybe time to upgrade :-) But I'll adjust the code then... at least try to do so. |
Currently there is no way to ever remove a key from the map, this can lead to accumulation of memory as it is strongly referencing the class. This adds a new method so keys can be removed from the map See eclipse#74 Signed-off-by: Christoph Läubrich <[email protected]>
@cstamas rebased and changed to java 7 style |
I have no idea why the ECA check fials, the ECA tool sais it is valid and I use it all the time for eclipse contributions... |
Hi @laeubi - thanks for the PR, just wondering if a simple |
( I also re-ran the ECA check and it passed, so seems to have been a temporary glitch ) |
I just thought it might be more flexible to check for a class, but a classloader would work for sure as well. |
@mcculls do you maybe want to take over the PR and just change it so it best fit the needs of sisu.inject project? I think the idea is quite clear on what to archive here? |
Retargeted PR against new default branch |
@cstamas please apply / use this as you find appropriate... |
* @param remove a tester that can decide if this key needs to be flushed or | ||
* not. | ||
*/ | ||
public void flushCacheFor( ClassTester remove ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add @since 0.9.0.M3
/** | ||
* Allows testing if a class should be flushed from the cache | ||
*/ | ||
public static interface ClassTester |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls add @since 0.9.0.M3
Superseded by #138 |
Currently there is no way to ever remove a key from the map, this can lead to accumulation of memory as it is strongly referencing the class.
This adds a new method so keys can be removed from the map
Fixes #74
@cstamas @gnodet can you take a look?