Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call TypeAwareExpressionEvaluator.evaluate(String,Class) if available #161

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Aug 29, 2024

Only enforce types in some places (where conversion afterwards never happens)

This closes #160

@kwin kwin requested review from cstamas and mcculls August 29, 2024 16:02
@kwin kwin force-pushed the feature/support-TypeAwareExpressionEvaluator-in-configuratonconverter branch 2 times, most recently from 98f5162 to 92a3066 Compare August 29, 2024 16:09
Only enforce types in some places (where conversion afterwards never
happens)

This closes #160
@kwin kwin force-pushed the feature/support-TypeAwareExpressionEvaluator-in-configuratonconverter branch from 92a3066 to 77e0db5 Compare August 29, 2024 16:12
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
62.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@kwin
Copy link
Contributor Author

kwin commented Sep 21, 2024

I am gonna merge beginning of next week if there are no concerns with this.

@kwin kwin merged commit 8bce6fe into main Sep 30, 2024
12 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TypeAwareExpressionEvaluator in AbstractConfigurationConverter
1 participant