Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jacoco + code coverage #151

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Fix jacoco + code coverage #151

merged 3 commits into from
Jun 3, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 3, 2024

There was a mix: profile "code-coverage" that was never activated but added coverage to ALL modules, while inject and plexus had their own plugin executions set that ran always.

@cstamas cstamas requested review from mcculls and kwin June 3, 2024 17:12
@cstamas cstamas self-assigned this Jun 3, 2024
cstamas added 2 commits June 3, 2024 19:15
As it causes all kind of cli breakage when invoking tools and
jvm.
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@cstamas cstamas merged commit 9a1b55e into main Jun 3, 2024
13 checks passed
@cstamas cstamas deleted the fix-jacoco branch June 3, 2024 17:48
@kwin
Copy link
Contributor

kwin commented Jun 3, 2024

@cstamas I don't get this, why do we need the profile multiple times? Also why do you manually configure sonar.coverage.jacoco.xmlReportPaths? Please explain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants