Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty values to overwrite default values #167

Open
kwin opened this issue Dec 10, 2022 · 1 comment
Open

Allow empty values to overwrite default values #167

kwin opened this issue Dec 10, 2022 · 1 comment

Comments

@kwin
Copy link
Contributor

kwin commented Dec 10, 2022

Due to the logic in https://github.com/eclipse/sisu.plexus/blob/27a29dc633e6b03753a3c8d29a033648630c8831/org.eclipse.sisu.plexus/src/org/codehaus/plexus/component/configurator/converters/AbstractConfigurationConverter.java#L49 it is not possible to overwrite any default value with an empty string.
That prevents supporting use cases like https://issues.apache.org/jira/browse/MNG-6434.

IMHO all explicit configuration values (even if empty) should take precedence over default values.
@michael-o
Copy link

Not this line: https://github.com/eclipse/sisu.plexus/blob/27a29dc633e6b03753a3c8d29a033648630c8831/org.eclipse.sisu.plexus/src/org/codehaus/plexus/component/configurator/converters/AbstractConfigurationConverter.java#L47?

@kwin kwin mentioned this issue Apr 13, 2023
Merged
@kwin kwin mentioned this issue Feb 24, 2024
Merged
@kwin kwin mentioned this issue Jun 25, 2024
Merged
@kwin kwin transferred this issue from eclipse-sisu/sisu.plexus Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwin @michael-o