-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNG-7763] Provide UTF-8 as a default value for project.build.sourceEncoding and project.reporting.outputEncoding #1085
Conversation
…ncoding and project.reporting.outputEncoding
The outcome is then there is no way to remove this and it will also apply to ALL projects. |
Isn't that the goal ? |
Maybe, but this should be known that due to Plexus we cannot null values. @kwin Can we know? I don't that this is a huge problem here, but people should still know whether it is possible or not. I haven't used anything else, but UTF-8 for the past 20 years. |
while you can override it in your own project (which is the case AFAIK) it is fine and I don't see how null and not be deterministic can be better than forcing the value to the OS one so guess we are good like that without handling null in the code. |
FTR: overwriting default values by empty string is not supported due to https://github.com/eclipse/sisu.plexus/issues/29 |
For those that want to override it to the Maven 3 behaviour, maybe you can introduce a magic value "OS_DEFAULT" that gets translated to not setting the encoding deeper down the implementation? +1 to default to UTF-8 |
I'd prefer |
Good point. |
I'd suggest that people that want the default encoding use |
You are totally right. Stupid me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the correction from @gnodet , I am fine with that. We need to properly document what is the scope of impact: Reactor or deps as well.
JIRA issue: https://issues.apache.org/jira/browse/MNG-7763
Discussion: https://lists.apache.org/thread/0mjosk1wp58fjvhz812htqfjot0n930g