Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate website #152

Closed
cstamas opened this issue Jun 3, 2024 · 14 comments · Fixed by #162
Closed

Consolidate website #152

cstamas opened this issue Jun 3, 2024 · 14 comments · Fixed by #162

Comments

@cstamas
Copy link
Member

cstamas commented Jun 3, 2024

We have some "minisite" here: https://github.com/eclipse-sisu/sisu-project/tree/main/docs
But we have "the site" here: https://github.com/eclipse-sisu/sisu-website

Consolidate the two, I'd really like to have out up to date site on https://eclipse.dev/sisu/ instead of some long GH pages URL.

@cstamas
Copy link
Member Author

cstamas commented Jun 3, 2024

@HomeOfTheWizard @mcculls @kwin ping

@cstamas
Copy link
Member Author

cstamas commented Jun 3, 2024

Also, sisu-website is now off, contains wrong URLs, etc, we need to sort that out.

@HomeOfTheWizard
Copy link
Contributor

HomeOfTheWizard commented Jun 3, 2024

I wasn't aware of this repo https://github.com/eclipse-sisu/sisu-website

But there is also this site that is still alive and which also have old links and info that needs to be corrected
https://projects.eclipse.org/projects/technology.sisu
I could not find the sources of it to create a PR.

BTW I can gladly help where I can on consolidating and fixing old info/links

@kwin
Copy link
Contributor

kwin commented Jun 4, 2024

But there is also this site that is still alive and which also have old links and info that needs to be corrected
https://projects.eclipse.org/projects/technology.sisu
I could not find the sources of it to create a PR.

Good catch. This can only be maintained through a form based UI by Sisu committers unfortunately.

@HomeOfTheWizard
Copy link
Contributor

HomeOfTheWizard commented Jul 26, 2024

I realized that using maven-core v3.9.6 or above in plugin dependencies, we do not need to use the sisu-maven-plugin anymore to create the index of annotated components, as explained here.
I think we should update that documentation as well.

@kwin
Copy link
Contributor

kwin commented Jul 26, 2024

Look at https://github.com/eclipse-sisu/sisu-project/blob/main/README.md#generation-of-named-index. You need the index, but it is usually created through the annotation processor (if contained in the classpath).

@HomeOfTheWizard
Copy link
Contributor

I think the functioning or failing of this index generation is a bit too silent.
I have a project where I was defining the sisu-maven-plugin explicitely before, now I just removed it (without touching the maven-compile-plugin config) and it still generates the index.
I do not see any APT processor activated during the compilation.

here is the project: https://github.com/HomeOfTheWizard/spring-bridge-maven-plugin

@kwin
Copy link
Contributor

kwin commented Jul 26, 2024

index is optional in general, mandatory for Maven though.

@HomeOfTheWizard
Copy link
Contributor

HomeOfTheWizard commented Jul 26, 2024

The index file is well generated in my META-INF/sisu folder, even though I did not use any of the solutions provided in the link.
Plus I see that the APT processor is disabled by default now with your PR on the version 0.9.0.M3

@HomeOfTheWizard
Copy link
Contributor

I just realized that when I upgrade from maven-core 3.9.7 to 3.9.8 the index is not generated anymore.
This validates my previous theory. I think it is because of the APT processor being desactivated in #105.
So the documentation on your link is correct for the version of maven core 3.9.8.
My issue was simply that I was using 3.9.7 :)
Mea culpa

@HomeOfTheWizard
Copy link
Contributor

I have created the folloing PR apache/maven-site#550

@HomeOfTheWizard
Copy link
Contributor

Also this one #158

@kwin
Copy link
Contributor

kwin commented Aug 29, 2024

kwin added a commit that referenced this issue Aug 30, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Aug 30, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Aug 30, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 8, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 9, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 9, 2024
Build with m-site-p

This closes #152
kwin added a commit to kwin/eclipse-sisu-eclipsefdn that referenced this issue Sep 9, 2024
The website built by m-site-p is contained in branch gh-pages

This relates to eclipse-sisu/sisu-project#152
kwin added a commit to kwin/eclipse-sisu-eclipsefdn that referenced this issue Sep 9, 2024
The website built by m-site-p is contained in branch gh-pages

This relates to eclipse-sisu/sisu-project#152
kwin added a commit that referenced this issue Sep 9, 2024
Build with m-site-p

This closes #152
kwin added a commit to kwin/eclipse-sisu-eclipsefdn that referenced this issue Sep 9, 2024
The website built by m-site-p is contained in branch gh-pages

This relates to eclipse-sisu/sisu-project#152
netomi pushed a commit to eclipse-sisu/.eclipsefdn that referenced this issue Sep 9, 2024
The website built by m-site-p is contained in branch gh-pages

This relates to eclipse-sisu/sisu-project#152
@kwin
Copy link
Contributor

kwin commented Sep 9, 2024

The new website is now live at https://eclipse-sisu.github.io/sisu-website/ and I requested serving that from https://eclipse.dev/sisu/ as well in https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4989

kwin added a commit that referenced this issue Sep 10, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 10, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 10, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 10, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 10, 2024
Build with m-site-p

This closes #152
kwin added a commit that referenced this issue Sep 10, 2024
Build with m-site-p

This closes #152
@kwin kwin closed this as completed in #162 Sep 11, 2024
kwin added a commit that referenced this issue Sep 11, 2024
Build with m-site-p

This closes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants