Update model to use transient data for ID references #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Test Results23 tests 23 ✅ 0s ⏱️ Results for commit 14cb816. ♻️ This comment has been updated with latest results. |
TruongQuangSB
requested changes
Mar 25, 2024
...set.feature.plazmodel/src/org/eclipse/set/feature/plazmodel/check/PlanungsBereichValid.xtend
Outdated
Show resolved
Hide resolved
...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/ssld/SsldTransformator.xtend
Outdated
Show resolved
Hide resolved
...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/sslr/SslrTransformator.xtend
Outdated
Show resolved
Hide resolved
...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/sslw/SslwTransformator.xtend
Outdated
Show resolved
Hide resolved
...ipse.set.feature.validation/src/org/eclipse/set/feature/validation/session/ModelSession.java
Show resolved
Hide resolved
...model.extensions/src/org/eclipse/set/ppmodel/extensions/PlanProSchnittstelleExtensions.xtend
Outdated
Show resolved
Hide resolved
...model.extensions/src/org/eclipse/set/ppmodel/extensions/PlanProSchnittstelleExtensions.xtend
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
pstuecker
force-pushed
the
transient-model
branch
from
9822d70 to
56a0f7b
Compare
This comment has been minimized.
This comment has been minimized.
java/bundles/org.eclipse.set.unittest.utils/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
java/bundles/org.eclipse.set.feature.siteplan.test/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
Co-authored-by: TruongQuangSB <[email protected]>
…NIFEST.MF Co-authored-by: TruongQuangSB <[email protected]>
TruongQuangSB
approved these changes
Apr 9, 2024
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the current approach of a (mostly autogenerated) model-to-model transformation (model <-> toolboxmodel) by adding transient attributes to the EMF model.
For the set repo there are a lot of changes:
org.eclipse.set.toolboxmodelis changed toorg.eclipse.set.model.planpro