-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify Ssld examplar and Free reporting section #1198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TruongQuangSB
commented
Dec 19, 2024
•
edited
Loading
edited
- Fix signal side distance
- Fix free reporting section length
- Modify Ssld examplar
This comment has been minimized.
This comment has been minimized.
Test Results121 tests ±0 121 ✅ ±0 18s ⏱️ -1s Results for commit de9ee40. ± Comparison against base commit 14f3adc. This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
mariusheine
requested changes
Dec 19, 2024
java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/graph/TopPath.java
Outdated
Show resolved
Hide resolved
java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/graph/TopPath.java
Outdated
Show resolved
Hide resolved
java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/graph/TopPath.java
Outdated
Show resolved
Hide resolved
...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/ssld/SsldTransformator.xtend
Show resolved
Hide resolved
...pse.set.feature.table.pt1/src/org/eclipse/set/feature/table/pt1/ssld/SsldTransformator.xtend
Show resolved
Hide resolved
java/bundles/org.eclipse.set.feature/rootdir/data/export/excel/ssld_vorlage.xlsx
Outdated
Show resolved
Hide resolved
mariusheine
requested changes
Dec 19, 2024
java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/graph/TopPath.java
Show resolved
Hide resolved
java/bundles/org.eclipse.set.basis/src/org/eclipse/set/basis/graph/TopPath.java
Outdated
Show resolved
Hide resolved
mariusheine
approved these changes
Dec 19, 2024
License summary❌ Not yet vetted dependencies:
Workflow run (with attached summary files): |
TruongQuangSB
added a commit
to SuB-PlanPro/set
that referenced
this pull request
Dec 20, 2024
* Modify Ssld examplar and Free reporting section * Improve after review * Ssld: Update calculation for dissolution section * Improve after review * Improve after review * Modify examplar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.