Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssks: Fix distance between neighbor track #1083

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Conversation

TruongQuangSB
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 22, 2024

Test Results

121 tests  ±0   121 ✅ ±0   17s ⏱️ -1s
 28 suites ±0     0 💤 ±0 
 28 files   ±0     0 ❌ ±0 

Results for commit f9e854b. ± Comparison against base commit 6f2be17.

This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@3e5d4f6b
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@43f0c2d1
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@205bed61
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@129fed45
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@23592946
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@42f9873e, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@18483b8b, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@5ba184fc, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@1e6d30c0, second=xxx], expected=multi/456/123/other=xxx]
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@45d64d27
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@7026b7ee
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@f096f37
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@3effd4f3
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@41f4fe5
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@4a122e68, expected=multi/container-id/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@41be8db9, expected=multi/456/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@13234ac9, second=other], expected=multi/container-id/element-id/other=other]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[2] TestData [input=Pair [first=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@536da29c, second=xxx], expected=multi/456/123/other=xxx]

♻️ This comment has been updated with latest results.

This comment has been minimized.

@mariusheine
Copy link
Contributor

/license-check

This comment has been minimized.

@mariusheine
Copy link
Contributor

@TruongQuangSB Looking at the table differences for the Ssks #1124 (comment) a lot of distances switched direction. Is this still correct then?

@TruongQuangSB
Copy link
Contributor Author

@TruongQuangSB Looking at the table differences for the Ssks #1124 (comment) a lot of distances switched direction. Is this still correct then?

i have analyse with TextView and looks change fine. We have here with direction of Signal Mast to defintion left/right side distance. But i give a strange, that is the direction of the mast and the signal aren't same 😄 . I think, we must first with Carsten declare

@mariusheine
Copy link
Contributor

@TruongQuangSB Looking at the table differences for the Ssks #1124 (comment) a lot of distances switched direction. Is this still correct then?

i have analyse with TextView and looks change fine. We have here with direction of Signal Mast to defintion left/right side distance. But i give a strange, that is the direction of the mast and the signal aren't same 😄 . I think, we must first with Carsten declare

@TruongQuangSB Alright. Will you clarify it with Carsten or shall we do it together?

@TruongQuangSB
Copy link
Contributor Author

TruongQuangSB commented Dec 10, 2024

@TruongQuangSB Looking at the table differences for the Ssks #1124 (comment) a lot of distances switched direction. Is this still correct then?

i have analyse with TextView and looks change fine. We have here with direction of Signal Mast to defintion left/right side distance. But i give a strange, that is the direction of the mast and the signal aren't same 😄 . I think, we must first with Carsten declare

@TruongQuangSB Alright. Will you clarify it with Carsten or shall we do it together?

@mariusheine After speak with Carsten, the beide direction is a illegal direction. Therefore it will be a lot WARNING symbol now 😄

@mariusheine mariusheine merged commit 381d4bd into main Dec 10, 2024
11 of 12 checks passed
@mariusheine mariusheine deleted the ssks/fix-leteral-distance branch December 10, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants