Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose LMDB Sail GC Configurations #5260

Open
odysa opened this issue Feb 27, 2025 · 2 comments
Open

Expose LMDB Sail GC Configurations #5260

odysa opened this issue Feb 27, 2025 · 2 comments
Labels
📶 enhancement issue is a new feature or improvement

Comments

@odysa
Copy link

odysa commented Feb 27, 2025

Problem description

VALUE_EVICTION_INTERVAL in LMDB is now hardcoded as 60 seconds. I want to expose this configuration so users can control the GC interval. Also, users should be able to disable/enable GC.

private static final long VALUE_EVICTION_INTERVAL = 60000; // 60 seconds

Preferred solution

Make VALUE_EVICTION_INTERVAL configurable and add it to LmdbStoreConfig

Special case: If VALUE_EVICTION_INTERVAL <= 0, the LMDB GC should be disabled.

Are you interested in contributing a solution yourself?

Yes

Alternatives you've considered

Alternatively, if VALUE_EVICTION_INTERVAL <= 0, the LMDB should throw an exception.
We should use an additional config enableGC to control GC.

Anything else?

No response

@odysa odysa added the 📶 enhancement issue is a new feature or improvement label Feb 27, 2025
odysa added a commit to odysa/rdf4j that referenced this issue Mar 1, 2025
odysa added a commit to odysa/rdf4j that referenced this issue Mar 1, 2025
odysa added a commit to odysa/rdf4j that referenced this issue Mar 1, 2025
@odysa
Copy link
Author

odysa commented Mar 4, 2025

@kenwenzel @hmottestad Hello, any thoughts on this configuration change? #5261

@hmottestad
Copy link
Contributor

I'm currently on holiday, but I think @kenwenzel should have the required permissions to review and merge this.

odysa added a commit to odysa/rdf4j that referenced this issue Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📶 enhancement issue is a new feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants