Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - skip listener for empty sail #1392

Closed
hmottestad opened this issue Apr 15, 2019 · 1 comment
Closed

SHACL - skip listener for empty sail #1392

hmottestad opened this issue Apr 15, 2019 · 1 comment
Assignees
@hmottestad
Labels
M1 Fixed in milestone 1 ⏩ performance 📦 SHACL affects the SHACL validator
Milestone
3.0.0

Comments

@hmottestad
Copy link
Contributor

When the base sail is empty, there is no need to use a listener, since the current state og the base sail will be equal to "added statements" at the end of the connection.
@hmottestad hmottestad added ⏩ performance 📦 SHACL affects the SHACL validator labels Apr 15, 2019
@hmottestad hmottestad added this to the 3.0 milestone Apr 15, 2019
@hmottestad hmottestad self-assigned this Apr 15, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 15, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1392 more performance logging and two optimizatio…
d4b8592 
…ns, one for skipping the listener when empty base sail, the other for using the underlying sail if it is a memory store, isolation level is NONE and RDFS is empty

Signed-off-by: Håvard Ottestad <[email protected]>
@hmottestad
Copy link
Contributor Author

Before

Benchmark                                   Mode  Cnt     Score    Error  Units
ComplexLargeBenchmark.noPreloadingParallel  avgt   10  8575.043 ± 67.893  ms/op

After

Benchmark                                   Mode  Cnt     Score    Error  Units
ComplexLargeBenchmark.noPreloadingParallel  avgt   10  6058.414 ± 96.680  ms/op

@hmottestad hmottestad mentioned this issue Apr 15, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 15, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1392 cleanup isolation level
c40c196 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 15, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1392 bug fix
1f3dc9f 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 15, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1392 another bug fix
b5ec479 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 15, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1392 another bug fix
b479e2b 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 23, 2019
@hmottestad
Merge branch 'develop' into issues/1350_shacl_new_memory_store
9f72469 
* develop:
  eclipse-rdf4j/rdf4j#1392 another bug fix
  eclipse-rdf4j/rdf4j#1392 another bug fix
  eclipse-rdf4j/rdf4j#1392 bug fix
  eclipse-rdf4j/rdf4j#1392 cleanup isolation level
  eclipse-rdf4j/rdf4j#1392 more performance logging and two optimizations, one for skipping the listener when empty base sail, the other for using the underlying sail if it is a memory store, isolation level is NONE and RDFS is empty

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/ShaclSailConnection.java
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 27, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
a64a78e 
* develop:
  eclipse-rdf4j/rdf4j#1397 more streams
  eclipse-rdf4j/rdf4j#1396 imrpoved benchmarks
  eclipse-rdf4j/rdf4j#1392 another bug fix
  eclipse-rdf4j/rdf4j#1392 another bug fix
  eclipse-rdf4j/rdf4j#1392 bug fix
  eclipse-rdf4j/rdf4j#1392 cleanup isolation level
  eclipse-rdf4j/rdf4j#1392 more performance logging and two optimizations, one for skipping the listener when empty base sail, the other for using the underlying sail if it is a memory store, isolation level is NONE and RDFS is empty
  eclipse-rdf4j/rdf4j#1391 min, max and class use SPARQL queries
  formatter
  eclipse-rdf4j/rdf4j#1390 check if data is sorted while adding it to the arraylist, skip sorting if the list is only size=1 or if the data is already sorted

Signed-off-by: Håvard Ottestad <[email protected]>
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
M1 Fixed in milestone 1 ⏩ performance 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad