Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - BulkedExternalInnerJoin issue #1384

Closed
hmottestad opened this issue Apr 6, 2019 · 0 comments
Closed

SHACL - BulkedExternalInnerJoin issue #1384

hmottestad opened this issue Apr 6, 2019 · 0 comments
Assignees
@hmottestad
Labels
🐞 bug issue is a bug M1 Fixed in milestone 1 📦 SHACL affects the SHACL validator
Milestone
3.0.0

Comments

@hmottestad
Copy link
Contributor

BulkedExternalInnerJoin stops prematurely when more than bulk size of left nodes with no right node.
@hmottestad hmottestad added 🐞 bug issue is a bug 📦 SHACL affects the SHACL validator labels Apr 6, 2019
@hmottestad hmottestad added this to the 3.0 milestone Apr 6, 2019
@hmottestad hmottestad self-assigned this Apr 6, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 6, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1384 test and fix
9547bfa 
Signed-off-by: Håvard Ottestad <[email protected]>
@hmottestad hmottestad mentioned this issue Apr 6, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 6, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1384 optimize
976db1d 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 6, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1384 bug fix
ded2ecd 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 6, 2019
@hmottestad
Merge pull request #221 from eclipse/issues/1384_BulkedExternalInnerJoin
d948d32 
eclipse-rdf4j/rdf4j#1384 test and fix
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 6, 2019
@hmottestad
Merge branch 'develop' into issues/1375_bigger_benchmark
b91be6a 
* develop:
  eclipse-rdf4j/rdf4j#1384 bug fix
  eclipse-rdf4j/rdf4j#1384 optimize
  formatter
  faster uniqueLang on empty base sail
  eclipse-rdf4j/rdf4j#1384 test and fix
  don't activate quick profile on skipTests
  shacl tests use logback explicitly instead of slf4j-simple
  eclipse-rdf4j/rdf4j#1290 allow to read and delete shapes
  eclipse-rdf4j/rdf4j#1236 clean install succesful
  eclipse-rdf4j/rdf4j#1236 moved test suites for geosparql, serql, shacl, and sparql
  eclipse-rdf4j/rdf4j#1236 moved tests for shacl and spin
  eclipse-rdf4j/rdf4j#1236 moved store and lucene test suites
  eclipse-rdf4j/rdf4j#1236 cleanup
  eclipse-rdf4j/rdf4j#1236 migrating sailmodel compliance [wip]
  eclipse-rdf4j/rdf4j#1236 sail compliance tests to respective modules
  fixed formatting
  eclipse-rdf4j/rdf4j#1229 compliance tests for Lucene itself

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/ShaclSailConnection.java
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 13, 2019
@hmottestad
Merge branch 'develop' into issues/1350_shacl_new_memory_store
17b2a08 
* develop: (40 commits)
  optimize imports and format
  eclipse-rdf4j/rdf4j#1375 bigger benchmark based on a generated file and option for logging performance per shape during validation
  potential bug fix and performance optimization
  formatter
  nicer query plans
  formatter
  eclipse-rdf4j/rdf4j#1388 configurable caching
  eclipse-rdf4j/rdf4j#1388 moved auto batched flushing
  moved added
  further reduce memory allowance in benchmark
  update benchmark
  eclipse-rdf4j/rdf4j#1388 clean up benchmark
  eclipse-rdf4j/rdf4j#1388 allow for cache less validation
  more utf8 and formatting
  eclipse-rdf4j/rdf4j#1388 periodically flush when loading big files in a single transaction without isolation
  formatting
  eclipse-rdf4j/rdf4j#1388 create benchmark
  clean up use of utf-8 and various other code cleanup
  eclipse-rdf4j/rdf4j#1384 bug fix
  eclipse-rdf4j/rdf4j#1384 optimize
  ...

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/pom.xml
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/AST/PropertyShape.java
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/ShaclSailConnection.java
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/benchmark/ComplexBenchmark.java
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 13, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
c0a9f96 
* develop: (57 commits)
  optimize imports and format
  eclipse-rdf4j/rdf4j#1375 bigger benchmark based on a generated file and option for logging performance per shape during validation
  potential bug fix and performance optimization
  formatter
  nicer query plans
  formatter
  eclipse-rdf4j/rdf4j#1388 configurable caching
  eclipse-rdf4j/rdf4j#1388 moved auto batched flushing
  moved added
  further reduce memory allowance in benchmark
  update benchmark
  eclipse-rdf4j/rdf4j#1388 clean up benchmark
  eclipse-rdf4j/rdf4j#1388 allow for cache less validation
  more utf8 and formatting
  eclipse-rdf4j/rdf4j#1388 periodically flush when loading big files in a single transaction without isolation
  formatting
  eclipse-rdf4j/rdf4j#1388 create benchmark
  clean up use of utf-8 and various other code cleanup
  eclipse-rdf4j/rdf4j#1384 bug fix
  eclipse-rdf4j/rdf4j#1384 optimize
  ...

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/Utils.java
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
🐞 bug issue is a bug M1 Fixed in milestone 1 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad