Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - maxCount should not query underlying store if that store is empty or doesn't contain relevant info #1380

Closed
hmottestad opened this issue Apr 3, 2019 · 0 comments
Closed

SHACL - maxCount should not query underlying store if that store is empty or doesn't contain relevant info #1380

hmottestad opened this issue Apr 3, 2019 · 0 comments
Assignees
@hmottestad
Labels
M1 Fixed in milestone 1 ⏩ performance 📦 SHACL affects the SHACL validator
Milestone
3.0.0

Comments

@hmottestad
Copy link
Contributor

Optimize maxCount.

  • Skip querying underlying store if empty.
  • Skip resources that didn't exist in the previous transaction
@hmottestad hmottestad added ⏩ performance 📦 SHACL affects the SHACL validator labels Apr 3, 2019
@hmottestad hmottestad added this to the 3.0 milestone Apr 3, 2019
@hmottestad hmottestad self-assigned this Apr 3, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 3, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1380 improved maxCount performance
ae36ec3 
Signed-off-by: Håvard Ottestad <[email protected]>
@hmottestad hmottestad mentioned this issue Apr 3, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 3, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1380 innerjoin
9dfdc77 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 3, 2019
@hmottestad
Merge branch 'develop' into issues/1375_bigger_benchmark
66b9fe2 
* develop:
  eclipse-rdf4j/rdf4j#1380 innerjoin
  eclipse-rdf4j/rdf4j#1380 improved maxCount performance

Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Apr 3, 2019
@hmottestad
Merge branch 'develop' into issues/1350_shacl_new_memory_store
1f64205 
* develop:
  inner joing fix
  eclipse-rdf4j/rdf4j#1380 innerjoin
  eclipse-rdf4j/rdf4j#1380 improved maxCount performance
  eclipse-rdf4j/rdf4j#1378 simplified code
  eclipse-rdf4j/rdf4j#1378 simple improvements
  eclipse-rdf4j/rdf4j#1378 benchmarks
  eclipse-rdf4j/rdf4j#1375 updated benchmarks
  eclipse-rdf4j/rdf4j#1375 added large benchmark and adjusted the complex benchmark shacl rules and optimisations

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/main/java/org/eclipse/rdf4j/sail/shacl/planNodes/BulkedExternalInnerJoin.java
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/benchmark/ComplexBenchmark.java
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
M1 Fixed in milestone 1 ⏩ performance 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad