Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHACL - support shape constraints that validate targets and not paths #1354

Closed
hmottestad opened this issue Mar 18, 2019 · 1 comment
Closed

SHACL - support shape constraints that validate targets and not paths #1354

hmottestad opened this issue Mar 18, 2019 · 1 comment
Assignees
@hmottestad
Labels
M1 Fixed in milestone 1 📦 SHACL affects the SHACL validator
Milestone
3.0.0

Comments

@hmottestad
Copy link
Contributor

Example:

ex:MyShape
	a sh:NodeShape ;
	sh:targetNode "hello" ;
	sh:datatype xsd:string .
@hmottestad hmottestad added the 📦 SHACL affects the SHACL validator label Mar 18, 2019
@hmottestad hmottestad added this to the 3.0 milestone Mar 18, 2019
@hmottestad hmottestad self-assigned this Mar 18, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 added test
e3f94cc 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 basic optional path support
ce7e906 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 simple support in StandardisedPlanHelper
b754e6c 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 targetNode and datatype
dfc3372 
Signed-off-by: Håvard Ottestad <[email protected]>
@hmottestad
Copy link
Contributor Author

hmottestad commented Mar 18, 2019 •
edited
Loading

don't forget to support as part of nested sh:or

hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 support for sh:class
cde0cae 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 added test
7c6cf29 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 basic optional path support
8b5525f 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 simple support in StandardisedPlanHelper
8017f87 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 targetNode and datatype
9542300 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 18, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 support for sh:class
21362ea 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 fix tuple comparison
fdaa8b7 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 support for sh:or with sh:nodeKind
232a70b 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 support for sh:class in sh:or
d74e030 
Signed-off-by: Håvard Ottestad <[email protected]>
@hmottestad hmottestad mentioned this issue Mar 19, 2019
Merged
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 19, 2019
@hmottestad
eclipse-rdf4j/rdf4j#1354 refactored test code and cleaned up imports
0814705 
Signed-off-by: Håvard Ottestad <[email protected]>
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 19, 2019
@hmottestad
Merge pull request #199 from eclipse/issues/1354_shacl_target_validation
bcd2524 
Issues/1354 shacl target validation closes eclipse-rdf4j/rdf4j#1354
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Mar 19, 2019
@hmottestad
Merge branch 'develop' into feature/101_shacl_w3c_tests
b5daec1 
* develop: (52 commits)
  eclipse-rdf4j/rdf4j#1354 refactored test code and cleaned up imports
  mvn formatter
  eclipse-rdf4j/rdf4j#1354 support for sh:class in sh:or
  eclipse-rdf4j/rdf4j#1354 support for sh:or with sh:nodeKind
  eclipse-rdf4j/rdf4j#1354 fix tuple comparison
  eclipse-rdf4j/rdf4j#1354 support for sh:class
  eclipse-rdf4j/rdf4j#1354 targetNode and datatype
  eclipse-rdf4j/rdf4j#1354 simple support in StandardisedPlanHelper
  eclipse-rdf4j/rdf4j#1354 basic optional path support
  eclipse-rdf4j/rdf4j#1354 added test
  eclipse-rdf4j/rdf4j#1337 fix spin test and improve test performance
  eclipse-rdf4j/rdf4j#1351 run formatter
  eclipse-rdf4j/rdf4j#1351 copy connection
  eclipse-rdf4j/rdf4j#1351 copy inferencer
  temporary switch back to old inferencer to avoid test failure
  fix compilation failure due to merge issues
  one-time pass of formatter with line-rejoining enabled
  one-time pass with line-rejoining enabled
  Update Jackson dependency
  formatter no longer joins lines back up if deliberately split
  ...

Signed-off-by: Håvard Ottestad <[email protected]>

# Conflicts:
#	shacl/src/test/java/org/eclipse/rdf4j/sail/shacl/Utils.java
@abrokenjester abrokenjester added the M1 Fixed in milestone 1 label Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmottestad hmottestad

Labels
M1 Fixed in milestone 1 📦 SHACL affects the SHACL validator
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@abrokenjester @hmottestad