Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHACL W3C Compliance Tests #1117

Open
abrokenjester opened this issue Oct 9, 2018 · 8 comments
Open

SHACL W3C Compliance Tests #1117

abrokenjester opened this issue Oct 9, 2018 · 8 comments
Assignees
Labels
📦 SHACL affects the SHACL validator

Comments

@abrokenjester
Copy link
Contributor

From @hmottestad on September 9, 2018 19:49

W3C have developed a bunch of compliance tests for SHACL. These should be included our SHACL tests.

Most will naturally fail at the moment since we only support a small subset of SHACL. However, this shouldn't fail the build.

Copied from original issue: eclipse/rdf4j-storage#101

@abrokenjester abrokenjester added the ✋ CQ-Pending requires a CQ to be approved label Oct 9, 2018
@abrokenjester
Copy link
Contributor Author

@hmottestad can you give me a link to where you grabbed this test suite from? Then I'll log a CQ for adding this content.

@abrokenjester
Copy link
Contributor Author

@abrokenjester
Copy link
Contributor Author

abrokenjester commented Oct 24, 2018

@hmottestad CQ logged https://dev.eclipse.org/ipzilla/show_bug.cgi?id=17918 . Sorry for the delay.

@hmottestad
Copy link
Contributor

Thanks @jeenbroekstra

We are miles away from being compliant with these official tests anyway.

@abrokenjester
Copy link
Contributor Author

CQ has been approved.

@abrokenjester abrokenjester removed the ✋ CQ-Pending requires a CQ to be approved label Dec 11, 2018
@hmottestad
Copy link
Contributor

@jeenbroekstra I'll try to switch from hard to soft failure by using "assume" (https://stackoverflow.com/questions/1689242/conditionally-ignoring-tests-in-junit-4)

@hmottestad hmottestad self-assigned this Jan 17, 2019
@abrokenjester abrokenjester added this to the 3.0 milestone Jan 26, 2019
@abrokenjester abrokenjester removed this from the 3.0.0 milestone Jul 28, 2019
hmottestad added a commit to eclipse-rdf4j/rdf4j-storage that referenced this issue Aug 15, 2019
@abrokenjester
Copy link
Contributor Author

@hmottestad is this issue still relevant?

@hmottestad
Copy link
Contributor

We aren't passing all the compliance tests yet, so they are still @ignored. I think we can keep this issue open until we can enable the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 SHACL affects the SHACL validator
Projects
None yet
Development

No branches or pull requests

3 participants