Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some UI Tests Leak thousends Resources without any warning #2379

Open
jukzi opened this issue Oct 10, 2024 · 2 comments
Open

Some UI Tests Leak thousends Resources without any warning #2379

jukzi opened this issue Oct 10, 2024 · 2 comments
Labels
test junit test related things

Comments

@jukzi
Copy link
Contributor

jukzi commented Oct 10, 2024

Can be locally reproduced by running ImportExistingProjectsWizardTest. The test passes locally but the windows user object climbes to 3000 while they should fall back to <1000 after each test case.
When i pause the UiTestSuite at that time the SWT Spy can be openend and shows a lot leaked shells:
image

Forcing a GC does NOT show any nondisposed warnings.

I hit onto that issues when SWTError: No more handles was logged in
https://download.eclipse.org/eclipse/downloads/drops4/I20241006-1800/testresults/consolelogs/ep434I-unit-win32-java17_win32.win32.x86_64_17_consolelog.txt

     [java] Shells: 
     [java]   invisible: Shell {Preferences} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {PartRenderingEngine's limbo} [layout=null]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   visible: Shell {Eclipse SDK} [layout=org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout@56c93e2a]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   visible: Shell {ui_sniff_folder - Eclipse SDK} [layout=org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout@106ed503]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Preferences} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   visible: Shell {Eclipse SDK} [layout=org.eclipse.e4.ui.workbench.renderers.swt.TrimmedPartLayout@531cc386]
     [java]   invisible: Shell {} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Import} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]
     [java]   invisible: Shell {Dialog Verification} [layout=GridLayout {numColumns=5 verticalSpacing=5}]

@jukzi jukzi added the test junit test related things label Oct 10, 2024
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Oct 10, 2024
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Oct 10, 2024
jukzi pushed a commit that referenced this issue Oct 10, 2024
jukzi pushed a commit to jukzi/eclipse.platform.ui that referenced this issue Oct 10, 2024
@jukzi
Copy link
Contributor Author

jukzi commented Oct 11, 2024

the ui.tests failures reduced from 474 to 351 in
https://download.eclipse.org/eclipse/downloads/drops4/I20241010-1800/testResults.php

jukzi pushed a commit that referenced this issue Oct 11, 2024
@BeckerWdf
Copy link
Contributor

the ui.tests failures reduced from 474 to 351 in https://download.eclipse.org/eclipse/downloads/drops4/I20241010-1800/testResults.php

Great. Thanks for taking care...

praveen-skp pushed a commit to praveen-skp/eclipse.platform.ui that referenced this issue Oct 14, 2024
praveen-skp pushed a commit to praveen-skp/eclipse.platform.ui that referenced this issue Oct 14, 2024
praveen-skp pushed a commit to praveen-skp/eclipse.platform.ui that referenced this issue Oct 14, 2024
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test junit test related things
Projects
None yet
Development

No branches or pull requests

2 participants