Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find/Replace overlay: search and replace input fields not vertically centered #2092

Closed
Tracked by #2021
HeikoKlare opened this issue Jul 16, 2024 · 0 comments · Fixed by #2097
Closed
Tracked by #2021

Find/Replace overlay: search and replace input fields not vertically centered #2092

HeikoKlare opened this issue Jul 16, 2024 · 0 comments · Fixed by #2097
Labels
enhancement New feature or request

Comments

@HeikoKlare
Copy link
Contributor

The introduction of the search and replace histories in the FindReplaceOverlay (#1990) have slightly changed the overlay's layout. In particular the text boxes are not vertically centered anymore. They are slightly off to the top.

Before #1990:
image

After #1990:
image

To me, the old placement looks better, thus we should try to restore it.
@HeikoKlare HeikoKlare added the enhancement New feature or request label Jul 16, 2024
@HeikoKlare HeikoKlare mentioned this issue Jul 16, 2024
Open
72 tasks
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 17, 2024
@HeikoKlare
Find/replace overlay: correct heights and vertical centering eclipse-…
68d0be3 
…platform#1997 eclipse-platform#2092

This adapts the defined margins in the FindReplaceOverlay, such that
1. there is no vertical cutoff of the buttons
2. the search and replace input boxes are vertically centered

Fixes eclipse-platform#1997
Fixes eclipse-platform#2092
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 17, 2024
@HeikoKlare
Find/replace overlay: correct heights and vertical centering eclipse-…
1750f97 
…platform#1997 eclipse-platform#2092

This adapts the defined margins in the FindReplaceOverlay, such that
1. there is no vertical cutoff of the buttons
2. the search and replace input boxes are vertically centered

Fixes eclipse-platform#1997
Fixes eclipse-platform#2092
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 17, 2024
@HeikoKlare
Find/replace overlay: correct heights and vertical centering eclipse-…
40f788a 
…platform#1997 eclipse-platform#2092

This adapts the defined margins in the FindReplaceOverlay, such that
1. there is no vertical cutoff of the buttons
2. the search and replace input boxes are vertically centered

Fixes eclipse-platform#1997
Fixes eclipse-platform#2092
@HeikoKlare HeikoKlare mentioned this issue Jul 17, 2024
Merged
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
@HeikoKlare @lathapatil
Find/replace overlay: correct heights and vertical centering eclipse-…
498f604 
…platform#1997 eclipse-platform#2092

This adapts the defined margins in the FindReplaceOverlay, such that
1. there is no vertical cutoff of the buttons
2. the search and replace input boxes are vertically centered

Fixes eclipse-platform#1997
Fixes eclipse-platform#2092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@HeikoKlare