Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find/Replace overlay: Search text not selected when switching to open overlay #2012

Closed
2 tasks done
Tracked by #2021
HannesWell opened this issue Jun 30, 2024 · 0 comments · Fixed by #2074
Closed
2 tasks done
Tracked by #2021

Find/Replace overlay: Search text not selected when switching to open overlay #2012

HannesWell opened this issue Jun 30, 2024 · 0 comments · Fixed by #2074
Labels
enhancement New feature or request

Comments

@HannesWell
Copy link
Member

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

If the search overlay is already open and I switch the cursor focus from the Editor back to the overlay using Ctrl+F the curer is placed in the beginning of the search text field. But if the text field is not empty, because it either contains the text of a preavuius Search or because the text selected in the editor when pressing Ctrl+F was added, then it would be often convenient if the entire text in the search field were full selected.
If the overlay is closed and opened with an initial search text (i.e. the text selected in the Editor while pressing Ctrl+F), then the behavior is already as desired and the search text is completely selected.

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@HannesWell HannesWell added the enhancement New feature or request label Jun 30, 2024
@Wittmaxi Wittmaxi mentioned this issue Jul 1, 2024
Open
72 tasks
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 11, 2024
@HeikoKlare
Find/replace: always select text when search input receives focus ecl…
47ee34e 
…ipse-platform#2012

When the FindReplaceOverlay is opened, the search input field is
initialized with the string currently selected in the target editor and
this string is selected in the search input field. In consequence,
starting to type after opening the dialog replaces the search string.
When there is no selection in the target editor, the current search
string is kept, but it is not selected. So starting to type will insert
further text before the current search string instead of replacing it.
This is inconsistent with the existing FindReplaceDialog.

This change improves the behavior to always select the search string
when the input field receives focus. According test cases are added.

Fixes eclipse-platform#2012
@HeikoKlare HeikoKlare mentioned this issue Jul 11, 2024
Merged
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 12, 2024
@HeikoKlare
Find/replace: always select text when search input receives focus ecl…
0196113 
…ipse-platform#2012

When the FindReplaceOverlay is opened, the search input field is
initialized with the string currently selected in the target editor and
this string is selected in the search input field. In consequence,
starting to type after opening the dialog replaces the search string.
When there is no selection in the target editor, the current search
string is kept, but it is not selected. So starting to type will insert
further text before the current search string instead of replacing it.
This is inconsistent with the existing FindReplaceDialog.

This change improves the behavior to always select the search string
when the input field receives focus. According test cases are added.

Fixes eclipse-platform#2012
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 14, 2024
@HeikoKlare
Find/replace: always select text when search input receives focus ecl…
6cdac6a 
…ipse-platform#2012

When the FindReplaceOverlay is opened, the search input field is
initialized with the string currently selected in the target editor and
this string is selected in the search input field. In consequence,
starting to type after opening the dialog replaces the search string.
When there is no selection in the target editor, the current search
string is kept, but it is not selected. So starting to type will insert
further text before the current search string instead of replacing it.
This is inconsistent with the existing FindReplaceDialog.

This change improves the behavior to always select the search string
when the input field receives focus. According test cases are added.

Fixes eclipse-platform#2012
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 15, 2024
@HeikoKlare
Find/replace: always select text when search input receives focus ecl…
5539350 
…ipse-platform#2012

When the FindReplaceOverlay is opened, the search input field is
initialized with the string currently selected in the target editor and
this string is selected in the search input field. In consequence,
starting to type after opening the dialog replaces the search string.
When there is no selection in the target editor, the current search
string is kept, but it is not selected. So starting to type will insert
further text before the current search string instead of replacing it.
This is inconsistent with the existing FindReplaceDialog.

This change improves the behavior to always select the search string
when the input field receives focus. According test cases are added.

Fixes eclipse-platform#2012
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
@HeikoKlare @lathapatil
Find/replace: always select text when search input receives focus ecl…
f558339 
…ipse-platform#2012

When the FindReplaceOverlay is opened, the search input field is
initialized with the string currently selected in the target editor and
this string is selected in the search input field. In consequence,
starting to type after opening the dialog replaces the search string.
When there is no selection in the target editor, the current search
string is kept, but it is not selected. So starting to type will insert
further text before the current search string instead of replacing it.
This is inconsistent with the existing FindReplaceDialog.

This change improves the behavior to always select the search string
when the input field receives focus. According test cases are added.

Fixes eclipse-platform#2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@HannesWell