Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find/Replace Overlay: unexpected key bindings on MacOS #2007

Closed
2 tasks done
Tracked by #2021
HeikoKlare opened this issue Jun 28, 2024 · 0 comments · Fixed by #2008
Closed
2 tasks done
Tracked by #2021

Find/Replace Overlay: unexpected key bindings on MacOS #2007

HeikoKlare opened this issue Jun 28, 2024 · 0 comments · Fixed by #2008
Labels
enhancement New feature or request macOS happens on macOS

Comments

@HeikoKlare
Copy link
Contributor

Steps to reproduce

The find/replace overlay can be opened via a keyboard shortcut and also supports a bunch of shortcuts to directly access the find or replace input field, (de-)activate options like regex search or case-sensitive search etc.
On Windows, all these shortcuts are accessible via CTRL+CHAR, while CHAR is some char key like "f", "r" or "w".
On MacOS, however, opening the overlay is done via CMD+F while all the other shortcuts within the overlay are done via CTRL+CHAR (including moving focus to the find input field via CTRL+F). This is because all bindings within the overlay use CTRL as a modifier while the opening action is bound to M1, i.e., the system-dependendent "modifier 1".

From what I experienced with MacOS so far, I would expect all the key bindings to use CMD as a modifier, like it is done for opening the overlay. This can achieved by using SWT.MOD1 instead of SWT.CTRL within the dialog, which still maps to CTRL on Windows.

Tested under this environment:

  • OS & version: MacOS Sonoma 14.5
  • Eclipse IDE/Platform version (as shown in Help > About): I20240627-1800

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@HeikoKlare HeikoKlare added enhancement New feature or request macOS happens on macOS labels Jun 28, 2024
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jun 28, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
b30aca9 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on Windows
and CMD on MacOS), while all key bindings within the overlay (such as
activating search options) use key bindings with CTRL as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used.

Fixes eclipse-platform#2007
@HeikoKlare HeikoKlare mentioned this issue Jun 28, 2024
Merged
@Wittmaxi Wittmaxi mentioned this issue Jul 1, 2024
Open
72 tasks
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 8, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
474c477 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on Windows
and CMD on MacOS), while all key bindings within the overlay (such as
activating search options) use key bindings with CTRL as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 8, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
d2a5ac3 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on Windows
and CMD on MacOS), while all key bindings within the overlay (such as
activating search options) use key bindings with CTRL as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 8, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
66e7f9d 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the tooltips
to (1) reflect the changed keys and (2) represent the MacOS modifier
keys via icons like at all other places.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
f6c67c0 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
bc31c07 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
b2c0218 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 9, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
2445c9f 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 11, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
3648bbf 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
HeikoKlare added a commit to HeikoKlare/eclipse.platform.ui that referenced this issue Jul 12, 2024
@HeikoKlare
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
ca7b586 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
lathapatil pushed a commit to lathapatil/eclipse.platform.ui that referenced this issue Oct 21, 2024
@HeikoKlare @lathapatil
Use consistent key bindings in FindReplaceOverlay on MacOS eclipse-pl…
94a0cef 
…atform#2007

Currently, the opening action for the find/replace overlay uses a key
binding with the OS-dependent "modifier 1" (mapping to CTRL on
Windows/Linux and CMD on MacOS), while all key bindings within the
overlay (such as activating search options) use key bindings with CTRL
as a modifier.

In order to unify the key bindings, this change adapts the key bindings
within the overlay to also use the OS-dependent "modifier 1", such that
on MacOS the CMD modifier is used. The change also adapts the shortcuts
to be represented as KeyStroke instances and uses them to match actual
key combinations as well as to produce the string representation of the
shortcuts for the tooltips.

Fixes eclipse-platform#2007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request macOS happens on macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use consistent key bindings in FindReplaceOverlay on MacOS #2007 HeikoKlare/eclipse.platform.ui
1 participant
@HeikoKlare