Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IllegalStateException toggling whitespace on/off in diff editor #1144

Closed
iloveeclipse opened this issue Sep 20, 2023 · 1 comment
Closed

IllegalStateException toggling whitespace on/off in diff editor #1144

iloveeclipse opened this issue Sep 20, 2023 · 1 comment
Assignees
@jukzi
Labels
bug Something isn't working regression
Milestone
4.30 M1

Comments

@iloveeclipse
Copy link
Member

Regression from #1115.

Open diff editor and toggle "Ignore whitespace" on/off - every time warning below is logged.

java.lang.IllegalStateException: beginTask should only be called once per instance. At least call done() before further invocations
	at org.eclipse.jface.operation.AccumulatingProgressMonitor.beginTask(AccumulatingProgressMonitor.java:148)
	at org.eclipse.core.runtime.SubMonitor.convert(SubMonitor.java:483)
	at org.eclipse.core.runtime.SubMonitor.convert(SubMonitor.java:449)
	at org.eclipse.compare.structuremergeviewer.StructureDiffViewer.lambda$7(StructureDiffViewer.java:532)
	at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:122)
Caused by: java.lang.IllegalStateException: beginTask(Generating Structure Differences, 100) was called here previously
	at org.eclipse.jface.operation.AccumulatingProgressMonitor.beginTask(AccumulatingProgressMonitor.java:155)
	at org.eclipse.compare.structuremergeviewer.StructureDiffViewer.lambda$7(StructureDiffViewer.java:531)
	... 1 more
@iloveeclipse iloveeclipse added bug Something isn't working regression labels Sep 20, 2023
@iloveeclipse iloveeclipse added this to the 4.30 M3 milestone Sep 20, 2023
@iloveeclipse
Copy link
Member Author

@jukzi : could you please check this one?

@jukzi jukzi self-assigned this Sep 22, 2023
jukzi pushed a commit to jukzi/eclipse.platform that referenced this issue Sep 22, 2023
@EcljpseB0T
StructureDiffViewer.diff: fix Progress eclipse-platform#1144
5770df7 
was IllegalStateException toggling whitespace on/off in diff editor

eclipse-platform/eclipse.platform.ui#1144
@jukzi jukzi mentioned this issue Sep 22, 2023
Merged
iloveeclipse pushed a commit to eclipse-platform/eclipse.platform that referenced this issue Sep 22, 2023
@EcljpseB0T @iloveeclipse
StructureDiffViewer.diff: fix Progress #1144
efe0dce 
was IllegalStateException toggling whitespace on/off in diff editor

eclipse-platform/eclipse.platform.ui#1144
@iloveeclipse iloveeclipse modified the milestones: 4.30 M3, 4.30 M1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jukzi jukzi

Labels
bug Something isn't working regression
Projects
None yet
Milestone
4.30 M1
Development

No branches or pull requests
2 participants
@iloveeclipse @jukzi