Fix help webapp compiling JSPs when run on Java 17+ #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasper shipped embeds ancient version of ecj which doesn't support targeting newer Java versions. As Eclipse is the author of ecj it makes sense to include our own version which is the absolute latest one. Removed workaround in tests explicitly adding jdt.core that is no longer needed Fixes #18
sravanlakkimsetti
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jasper shipped embeds ancient version of ecj which doesn't support
targeting newer Java versions. As Eclipse is the author of ecj it makes
sense to include our own version which is the absolute latest one.
Removed workaround in tests explicitly adding jdt.core that is no longer
needed
Fixes #18