[Win32] Summarize ICoreWebView2* instances in WebViewWrapper #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
refactor_edge_webview
branch
2 times, most recently
from
154cedf to
d65226e
Compare
amartya4256
force-pushed
the
refactor_edge_webview
branch
from
d65226e to
50031ab
Compare
HeikoKlare
force-pushed
the
refactor_edge_webview
branch
from
50031ab to
7da3c89
Compare
HeikoKlare
changed the title
HeikoKlare
force-pushed
the
refactor_edge_webview
branch
4 times, most recently
from
429f06a to
58ba07e
Compare
HeikoKlare
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Definitely a reasonable cleanup, thanks! I have just removed the change of the timeout in browser tests, as it was unrelated to this PR (I guess it was accidentally taken over from #1752).
HeikoKlare
force-pushed
the
refactor_edge_webview
branch
from
58ba07e to
df8a492
Compare
This commit contributes to refactoring of all the ICoreWebView2* instances into a wrapper class WebViewWrapper for better encapsulation and fault proof initialization using a single future. Contributes to eclipse-platform#669
HeikoKlare
force-pushed
the
refactor_edge_webview
branch
from
df8a492 to
2205d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to refactoring of all the webView* instances into a wrapper class WebViewWrapper for better encapsulation and fault proof initialization using a single future.
Contributes to #669