Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max time to create Edge browser in tests. #1677

Conversation

fedejeanne
Copy link
Contributor

Fixes #1676

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Test Results

   383 files  + 1     383 suites  +1   6m 0s ⏱️ -47s
 4 287 tests +35   4 275 ✅ +33  12 💤 +3  0 ❌  - 1 
12 343 runs  +35  12 248 ✅ +32  95 💤 +4  0 ❌  - 1 

Results for commit 2e3df4c. ± Comparison against base commit d26d0e3.

♻️ This comment has been updated with latest results.

@fedejeanne fedejeanne marked this pull request as ready for review December 18, 2024 12:02
@fedejeanne fedejeanne closed this Dec 18, 2024
@fedejeanne fedejeanne deleted the increase_timeout_browser_creation branch December 18, 2024 12:06
@fedejeanne fedejeanne restored the increase_timeout_browser_creation branch December 20, 2024 19:46
@fedejeanne fedejeanne reopened this Dec 20, 2024
@fedejeanne fedejeanne marked this pull request as draft December 20, 2024 19:47
@fedejeanne fedejeanne force-pushed the increase_timeout_browser_creation branch from 25568a4 to 938c51c Compare December 20, 2024 20:06
@fedejeanne
Copy link
Contributor Author

Test failures unrelated: #1523

@fedejeanne fedejeanne merged commit 639969b into eclipse-platform:master Dec 20, 2024
9 of 14 checks passed
@fedejeanne fedejeanne deleted the increase_timeout_browser_creation branch December 20, 2024 21:59
@HeikoKlare
Copy link
Contributor

@fedejeanne can you please elaborate why this is a proper fix for #1676?
The timeout of 10 seconds for the browser instantiations was intentional. I also faced the problem of intermittend instantiation issues (running into timeout) when creating #672 (which was the reason why I never merged for such a long time), but considered that as an indicator for some actualy bug, as the instantiation should never take longer than 20 seconds. Just imagine that this situation occurs during productive use.
If I remember correctly, the reason why a higher timeout "resolves" the issue is that messages in the OS message queue are dropped when not being processed for a specific amount of time (something around 20 seconds), which is why I expected this to be a symptom of a bug in the message processing of the Edge browser implementation that requires resolution.

@fedejeanne
Copy link
Contributor Author

It's not a proper fix for a productive issue (I haven't faced any though), it just works for the tests. My main goal was to avoid flaky tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail because creating the Edge browser for the tests takes too long
2 participants